JS: Address review comments

Author: asger-semmle

javascript/ql/src/semmle/javascript/dataflow/Nodes.qll

@@ -868,7 +868,7 @@ module ClassNode {
       result = getAPrototypeReference().getAPropertySource(name)
       or
       kind = MemberKind::method() and
-      result = getConstructor().getReceiver().getAPropertyWrite(name).getRhs().getALocalSource()
+      result = getConstructor().getReceiver().getAPropertySource(name)
       or
       exists(PropertyAccessor accessor |
         accessor = getAnAccessor(kind) and

javascript/ql/src/semmle/javascript/dataflow/internal/FlowSteps.qll

@@ -102,11 +102,11 @@ private module CachedSteps {
    * or one of its super classes.
    */
   cached
-  predicate callResolvesToClass(DataFlow::InvokeNode invoke, DataFlow::ClassNode cls, string name) {
+  predicate callResolvesToMember(DataFlow::InvokeNode invoke, DataFlow::ClassNode cls, string name) {
     invoke = cls.getAnInstanceReference().getAMethodCall(name)
     or
     exists(DataFlow::ClassNode subclass |
-      callResolvesToClass(invoke, subclass, name) and
+      callResolvesToMember(invoke, subclass, name) and
       not exists(subclass.getAnInstanceMember(name)) and
       cls = subclass.getADirectSuperClass()
     )
@@ -120,7 +120,7 @@ private module CachedSteps {
     f = invk.getACallee(0)
     or
     exists(DataFlow::ClassNode cls, string name |
-      callResolvesToClass(invk, cls, name) and
+      callResolvesToMember(invk, cls, name) and
       f = cls.getInstanceMethod(name).getFunction()
     )
   }