C++: revert InlineAsm subclassing SideEffectOpcode

Author: Robert Marsh

cpp/ql/src/semmle/code/cpp/ir/implementation/Opcode.qll

@@ -215,6 +215,6 @@ module Opcode {
   class BufferWriteSideEffect extends WriteSideEffectOpcode, BufferAccessOpcode, TBufferWriteSideEffect { override final string toString() { result = "BufferWriteSideEffect" } }
   class BufferMayWriteSideEffect extends MayWriteSideEffectOpcode, BufferAccessOpcode, TBufferMayWriteSideEffect { override final string toString() { result = "BufferMayWriteSideEffect" } }
   class Chi extends Opcode, TChi { override final string toString() { result = "Chi" } }
-  class InlineAsm extends MayWriteSideEffectOpcode, TInlineAsm { override final string toString() { result = "InlineAsm" } }
+  class InlineAsm extends Opcode, TInlineAsm { override final string toString() { result = "InlineAsm" } }
   class Unreached extends Opcode, TUnreached { override final string toString() { result = "Unreached" } }
 }

cpp/ql/test/library-tests/ir/ir/raw_ir.expected

@@ -5006,7 +5006,7 @@ ir.cpp:
 # 1099|     mu0_2(unknown)    = UnmodeledDefinition      : 
 # 1099|     r0_3(glval<int>)  = VariableAddress[x]       : 
 # 1099|     mu0_4(int)        = InitializeParameter[x]   : &:r0_3
-# 1100|     mu0_5(unknown)    = ^InlineAsm               : ~mu0_2
+# 1100|     mu0_5(unknown)    = InlineAsm                : ~mu0_2
 # 1101|     r0_6(glval<int>)  = VariableAddress[#return] : 
 # 1101|     r0_7(glval<int>)  = VariableAddress[x]       : 
 # 1101|     r0_8(int)         = Load                     : &:r0_7, ~mu0_2
@@ -5033,7 +5033,7 @@ ir.cpp:
 # 1106|     r0_12(glval<unsigned int &>) = VariableAddress[b]     : 
 # 1106|     r0_13(glval<unsigned int &>) = VariableAddress[c]     : 
 # 1106|     r0_14(glval<unsigned int &>) = VariableAddress[d]     : 
-# 1106|     mu0_15(unknown)              = ^InlineAsm             : ~mu0_2, 0:r0_11, 1:r0_12, 2:r0_13, 3:r0_14
+# 1106|     mu0_15(unknown)              = InlineAsm              : ~mu0_2, 0:r0_11, 1:r0_12, 2:r0_13, 3:r0_14
 # 1111|     v0_16(void)                  = NoOp                   : 
 # 1104|     v0_17(void)                  = ReturnVoid             : 
 # 1104|     v0_18(void)                  = UnmodeledUse           : mu*

cpp/ql/test/library-tests/ir/ssa/aliased_ssa_ir.expected

@@ -719,7 +719,7 @@ ssa.cpp:
 #  179|     mu0_2(unknown)     = UnmodeledDefinition      : 
 #  179|     r0_3(glval<int *>) = VariableAddress[p]       : 
 #  179|     m0_4(int *)        = InitializeParameter[p]   : &:r0_3
-#  180|     m0_5(unknown)      = ^InlineAsm               : ~mu0_2
+#  180|     m0_5(unknown)      = InlineAsm                : ~mu0_2
 #  180|     m0_6(unknown)      = Chi                      : total:m0_1, partial:m0_5
 #  181|     r0_7(glval<int>)   = VariableAddress[#return] : 
 #  181|     r0_8(glval<int *>) = VariableAddress[p]       : 
@@ -752,7 +752,7 @@ ssa.cpp:
 #  186|     r0_16(glval<unsigned int &>) = VariableAddress[b]     : 
 #  186|     r0_17(glval<unsigned int &>) = VariableAddress[c]     : 
 #  186|     r0_18(glval<unsigned int &>) = VariableAddress[d]     : 
-#  186|     m0_19(unknown)               = ^InlineAsm             : ~mu0_2, 0:r0_15, 1:r0_16, 2:r0_17, 3:r0_18
+#  186|     m0_19(unknown)               = InlineAsm              : ~mu0_2, 0:r0_15, 1:r0_16, 2:r0_17, 3:r0_18
 #  186|     m0_20(unknown)               = Chi                    : total:m0_14, partial:m0_19
 #  192|     v0_21(void)                  = NoOp                   : 
 #  184|     v0_22(void)                  = ReturnVoid             : 

cpp/ql/test/library-tests/ir/ssa/unaliased_ssa_ir.expected

@@ -691,7 +691,7 @@ ssa.cpp:
 #  179|     mu0_2(unknown)     = UnmodeledDefinition      : 
 #  179|     r0_3(glval<int *>) = VariableAddress[p]       : 
 #  179|     m0_4(int *)        = InitializeParameter[p]   : &:r0_3
-#  180|     mu0_5(unknown)     = ^InlineAsm               : ~mu0_2
+#  180|     mu0_5(unknown)     = InlineAsm                : ~mu0_2
 #  181|     r0_6(glval<int>)   = VariableAddress[#return] : 
 #  181|     r0_7(glval<int *>) = VariableAddress[p]       : 
 #  181|     r0_8(int *)        = Load                     : &:r0_7, m0_4
@@ -719,7 +719,7 @@ ssa.cpp:
 #  186|     r0_12(glval<unsigned int &>) = VariableAddress[b]     : 
 #  186|     r0_13(glval<unsigned int &>) = VariableAddress[c]     : 
 #  186|     r0_14(glval<unsigned int &>) = VariableAddress[d]     : 
-#  186|     mu0_15(unknown)              = ^InlineAsm             : ~mu0_2, 0:r0_11, 1:r0_12, 2:r0_13, 3:r0_14
+#  186|     mu0_15(unknown)              = InlineAsm              : ~mu0_2, 0:r0_11, 1:r0_12, 2:r0_13, 3:r0_14
 #  192|     v0_16(void)                  = NoOp                   : 
 #  184|     v0_17(void)                  = ReturnVoid             : 
 #  184|     v0_18(void)                  = UnmodeledUse           : mu*