Update python/ql/src/experimental/dataflow/internal/DataFlowPublic.qll

yoff · RasmusWL · web-flow · commit 5efc06da2c87 · 2020-09-14T17:08:39.000+02:00
Co-authored-by: Rasmus Wriedt Larsen &lt;rasmuswriedtlarsen@gmail.com&gt;
diff --git a/python/ql/src/experimental/dataflow/internal/DataFlowPublic.qll b/python/ql/src/experimental/dataflow/internal/DataFlowPublic.qll
@@ -157,8 +157,9 @@ class GuardNode extends ControlFlowNode {
 
   GuardNode() { this = conditionBlock.getLastNode() }
 
-  predicate controlsBlock(BasicBlock b, boolean testIsTrue) {
-    conditionBlock.controls(b, testIsTrue)
+  /** Holds if this guard controls block `b` upon evaluating to `branch`. */
+  predicate controlsBlock(BasicBlock b, boolean branch) {
+    conditionBlock.controls(b, branch)
   }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -157,8 +157,9 @@ class GuardNode extends ControlFlowNode {`
`157`	`157`
`158`	`158`	`GuardNode() { this = conditionBlock.getLastNode() }`
`159`	`159`
`160`		`- predicate controlsBlock(BasicBlock b, boolean testIsTrue) {`
`161`		`- conditionBlock.controls(b, testIsTrue)`
	`160`	+ /** Holds if this guard controls block `b` upon evaluating to `branch`. */
	`161`	`+ predicate controlsBlock(BasicBlock b, boolean branch) {`
	`162`	`+ conditionBlock.controls(b, branch)`
`162`	`163`	`}`
`163`	`164`	`}`
`164`	`165`