Merge pull request #6000 from tamasvajk/feature/extract-non-public-symbols

C#: Change compilation settings to include all non-public symbols

Author: tamasvajk

csharp/extractor/Semmle.Extraction.CSharp/Extractor/Extractor.cs

@@ -416,9 +416,10 @@ private static ExitCode AnalyseTracing(
                         compilerArguments.CompilationName,
                         syntaxTrees,
                         references,
-                        compilerArguments.CompilationOptions.
-                            WithAssemblyIdentityComparer(DesktopAssemblyIdentityComparer.Default).
-                            WithStrongNameProvider(new DesktopStrongNameProvider(compilerArguments.KeyFileSearchPaths))
+                        compilerArguments.CompilationOptions
+                            .WithAssemblyIdentityComparer(DesktopAssemblyIdentityComparer.Default)
+                            .WithStrongNameProvider(new DesktopStrongNameProvider(compilerArguments.KeyFileSearchPaths))
+                            .WithMetadataImportOptions(MetadataImportOptions.All)
                         );
                 },
                 (compilation, options) => analyser.EndInitialize(compilerArguments, options, compilation),

csharp/ql/test/library-tests/conversion/reftype/RefType.expected

@@ -1,5 +1,7 @@
 | Byte[] | Object |
 | Byte[] | dynamic |
+| Byte[][] | Object |
+| Byte[][] | dynamic |
 | C1 | Object |
 | C1 | dynamic |
 | C1[] | ICollection<C1> |
@@ -183,6 +185,8 @@
 | IReadOnlyList<T4> | dynamic |
 | Int16[] | Object |
 | Int16[] | dynamic |
+| Int32[,] | Object |
+| Int32[,] | dynamic |
 | Int32[] | Object |
 | Int32[] | dynamic |
 | Int64[] | Object |
@@ -221,12 +225,15 @@
 | T5 | C1 |
 | T5 | Object |
 | T5 | dynamic |
+| UInt16[][] | Object |
+| UInt16[][] | dynamic |
 | UInt32[] | Object |
 | UInt32[] | dynamic |
 | UInt64[] | Object |
 | UInt64[] | dynamic |
 | dynamic | Object |
 | null | Byte[] |
+| null | Byte[][] |
 | null | C1 |
 | null | C1[] |
 | null | C2 |
@@ -279,6 +286,7 @@
 | null | IReadOnlyList<T3> |
 | null | IReadOnlyList<T4> |
 | null | Int16[] |
+| null | Int32[,] |
 | null | Int32[] |
 | null | Int64[] |
 | null | Object |
@@ -289,6 +297,7 @@
 | null | T4 |
 | null | T4[] |
 | null | T5 |
+| null | UInt16[][] |
 | null | UInt32[] |
 | null | UInt64[] |
 | null | dynamic |

csharp/ql/test/library-tests/csharp8/UnmanagedGenericStructs.ql

@@ -1,5 +1,5 @@
 import csharp
 
 from TypeParameter tp
-where tp.getConstraints().hasUnmanagedTypeConstraint()
+where tp.getConstraints().hasUnmanagedTypeConstraint() and tp.fromSource()
 select tp, "This type parameter is unmanaged."

csharp/ql/test/library-tests/dataflow/global/GetAnOutNode.expected

@@ -227,6 +227,10 @@
 | file://:0:0:0:0 | [summary] call to continuationFunction in ContinueWith | normal | file://:0:0:0:0 | [summary] read: return (normal) of argument 0 in ContinueWith |
 | file://:0:0:0:0 | [summary] call to continuationFunction in ContinueWith | normal | file://:0:0:0:0 | [summary] read: return (normal) of argument 0 in ContinueWith |
 | file://:0:0:0:0 | [summary] call to continuationFunction in ContinueWith | normal | file://:0:0:0:0 | [summary] read: return (normal) of argument 0 in ContinueWith |
+| file://:0:0:0:0 | [summary] call to continuationFunction in ContinueWith | normal | file://:0:0:0:0 | [summary] read: return (normal) of argument 0 in ContinueWith |
+| file://:0:0:0:0 | [summary] call to continuationFunction in ContinueWith | normal | file://:0:0:0:0 | [summary] read: return (normal) of argument 0 in ContinueWith |
+| file://:0:0:0:0 | [summary] call to continuationFunction in ContinueWith | normal | file://:0:0:0:0 | [summary] read: return (normal) of argument 0 in ContinueWith |
+| file://:0:0:0:0 | [summary] call to continuationFunction in ContinueWith | normal | file://:0:0:0:0 | [summary] read: return (normal) of argument 0 in ContinueWith |
 | file://:0:0:0:0 | [summary] call to elementSelector in GroupBy | normal | file://:0:0:0:0 | [summary] read: return (normal) of argument 2 in GroupBy |
 | file://:0:0:0:0 | [summary] call to elementSelector in GroupBy | normal | file://:0:0:0:0 | [summary] read: return (normal) of argument 2 in GroupBy |
 | file://:0:0:0:0 | [summary] call to elementSelector in GroupBy | normal | file://:0:0:0:0 | [summary] read: return (normal) of argument 2 in GroupBy |
@@ -313,3 +317,5 @@
 | file://:0:0:0:0 | [summary] call to valueFactory in Lazy | normal | file://:0:0:0:0 | [summary] read: return (normal) of argument 0 in Lazy |
 | file://:0:0:0:0 | [summary] call to valueFactory in Lazy | normal | file://:0:0:0:0 | [summary] read: return (normal) of argument 0 in Lazy |
 | file://:0:0:0:0 | [summary] call to valueFactory in Lazy | normal | file://:0:0:0:0 | [summary] read: return (normal) of argument 0 in Lazy |
+| file://:0:0:0:0 | [summary] call to valueFactory in Lazy | normal | file://:0:0:0:0 | [summary] read: return (normal) of argument 0 in Lazy |
+| file://:0:0:0:0 | [summary] call to valueSelector in Task | normal | file://:0:0:0:0 | [summary] read: return (normal) of argument 0 in Task |