Python: Fix bad join

yoff · yoff · commit 6408ee2eaf9d · 2021-04-20T20:03:06.000+02:00
diff --git a/python/ql/src/Security/CWE-327/InsecureProtocol.ql b/python/ql/src/Security/CWE-327/InsecureProtocol.ql
@@ -25,6 +25,8 @@ class ProtocolConfiguration extends DataFlow::Node {
     or
     unsafe_context_creation(this, _)
   }
+
+  AstNode getNode() { result = this.asCfgNode().(CallNode).getFunction().getNode() }
 }
 
 // Helper for pretty printer `callName`.
@@ -36,9 +38,7 @@ class ProtocolConfiguration extends DataFlow::Node {
 // we have to extend @py_ast_node.
 class Nameable extends @py_ast_node {
   Nameable() {
-    exists(ProtocolConfiguration protocolConfiguration |
-      this = protocolConfiguration.asCfgNode().(CallNode).getFunction().getNode()
-    )
+    this = any(ProtocolConfiguration pc).getNode()
     or
     exists(Nameable attr | this = attr.(Attribute).getObject())
   }

Original file line number	Diff line number	Diff line change
`@@ -25,6 +25,8 @@ class ProtocolConfiguration extends DataFlow::Node {`
`25`	`25`	`or`
`26`	`26`	`unsafe_context_creation(this, _)`
`27`	`27`	`}`
	`28`	`+`
	`29`	`+ AstNode getNode() { result = this.asCfgNode().(CallNode).getFunction().getNode() }`
`28`	`30`	`}`
`29`	`31`
`30`	`32`	// Helper for pretty printer `callName`.
`@@ -36,9 +38,7 @@ class ProtocolConfiguration extends DataFlow::Node {`
`36`	`38`	`// we have to extend @py_ast_node.`
`37`	`39`	`class Nameable extends @py_ast_node {`
`38`	`40`	`Nameable() {`
`39`		`- exists(ProtocolConfiguration protocolConfiguration \|`
`40`		`- this = protocolConfiguration.asCfgNode().(CallNode).getFunction().getNode()`
`41`		`- )`
	`41`	`+ this = any(ProtocolConfiguration pc).getNode()`
`42`	`42`	`or`
`43`	`43`	`exists(Nameable attr \| this = attr.(Attribute).getObject())`
`44`	`44`	`}`