C++: Remove uses of getQualifiedName

This removes all uses of `Declaration.getQualifiedName` that I think can
be removed without changing any behaviour. The following uses in the
LGTM default suite remain:

* `cpp/ql/src/Security/CWE/CWE-121/UnterminatedVarargsCall.ql` (in `select`).
* `cpp/ql/src/semmle/code/cpp/dataflow/internal/DataFlowDispatch.qll` (needs template args).
* `cpp/ql/src/semmle/code/cpp/security/FunctionWithWrappers.qll` (used for alert messages).

Author: jbj

cpp/ql/src/Critical/InitialisationNotRun.ql

@@ -20,7 +20,7 @@ predicate global(GlobalVariable v) {
 }
 
 predicate mainCalled(Function f) {
-  f.getQualifiedName() = "main"
+  f.hasGlobalName("main")
   or
   exists(Function caller | mainCalled(caller) and allCalls(caller, f))
 }

cpp/ql/src/Critical/SizeCheck.ql

@@ -17,12 +17,12 @@ import cpp
 class Allocation extends FunctionCall {
   Allocation() {
     exists(string name |
-      this.getTarget().hasQualifiedName(name) and
+      this.getTarget().hasGlobalName(name) and
       (name = "malloc" or name = "calloc" or name = "realloc")
     )
   }
 
-  string getName() { result = this.getTarget().getQualifiedName() }
+  private string getName() { this.getTarget().hasGlobalName(result) }
 
   int getSize() {
     this.getName() = "malloc" and

cpp/ql/src/Critical/SizeCheck2.ql

@@ -17,12 +17,12 @@ import cpp
 class Allocation extends FunctionCall {
   Allocation() {
     exists(string name |
-      this.getTarget().hasQualifiedName(name) and
+      this.getTarget().hasGlobalName(name) and
       (name = "malloc" or name = "calloc" or name = "realloc")
     )
   }
 
-  string getName() { result = this.getTarget().getQualifiedName() }
+  private string getName() { this.getTarget().hasGlobalName(result) }
 
   int getSize() {
     this.getName() = "malloc" and

cpp/ql/src/DefaultOptions.qll

@@ -61,7 +61,7 @@ class Options extends string
    */
   predicate exits(Function f) {
     f.getAnAttribute().hasName("noreturn") or
-    exists(string name | f.getQualifiedName() = name |
+    exists(string name | f.hasGlobalName(name) |
       name = "exit" or
       name = "_exit" or
       name = "abort" or

cpp/ql/src/Likely Bugs/Memory Management/ReturnCstrOfLocalStdString.ql

@@ -58,11 +58,11 @@ predicate refToStdString(Expr e, ConstructorCall source) {
  * will also become invalid.
  */
 predicate flowFunction(Function fcn, int argIndex) {
-  (fcn.getQualifiedName() = "_JNIEnv::NewStringUTF" and argIndex = 0)
+  (fcn.hasQualifiedName("", "_JNIEnv", "NewStringUTF") and argIndex = 0)
   or
-  (fcn.getQualifiedName() = "art::JNI::NewStringUTF" and argIndex = 1)
+  (fcn.hasQualifiedName("art", "JNI", "NewStringUTF") and argIndex = 1)
   or
-  (fcn.getQualifiedName() = "art::CheckJNI::NewStringUTF" and argIndex = 1)
+  (fcn.hasQualifiedName("art", "CheckJNI", "NewStringUTF") and argIndex = 1)
 
   // Add other functions that behave like NewStringUTF here.
 }

cpp/ql/src/Metrics/Files/FNumberOfTests.ql

@@ -13,13 +13,10 @@ import cpp
 
 Expr getTest() {
     // cppunit tests; https://freedesktop.org/wiki/Software/cppunit/
-    exists(Function f | result.(FunctionCall).getTarget() = f
-                    and f.getNamespace().getName() = "CppUnit"
-                    and f.getName() = "addTest")
+    result.(FunctionCall).getTarget().hasQualifiedName("CppUnit", _, "addTest")
     or
     // boost tests; http://www.boost.org/
-    exists(Function f | result.(FunctionCall).getTarget() = f
-                    and f.getQualifiedName() = "boost::unit_test::make_test_case")
+    result.(FunctionCall).getTarget().hasQualifiedName("boost::unit_test", "make_test_case")
 }
 
 from File f, int n

cpp/ql/src/Security/CWE/CWE-022/TaintedPath.ql

@@ -23,7 +23,7 @@ import semmle.code.cpp.security.TaintTracking
  */
 class FileFunction extends FunctionWithWrappers {
   FileFunction() {
-    exists(string nme | this.getQualifiedName() = nme |
+    exists(string nme | this.hasGlobalName(nme) |
       nme = "fopen" or
       nme = "_fopen" or
       nme = "_wfopen" or
@@ -32,10 +32,7 @@ class FileFunction extends FunctionWithWrappers {
       nme = "_wopen" or
 
       // create file function on windows
-      nme.matches("CreateFile%") or
-
-      // Objective C standard library
-      nme.matches("NSFileHandle%::+fileHandleFor%AtPath:")
+      nme.matches("CreateFile%")
     )
     or
     (

cpp/ql/src/Security/CWE/CWE-676/PotentiallyDangerousFunction.ql

@@ -12,7 +12,7 @@
 import cpp
 
 predicate potentiallyDangerousFunction(Function f, string message) {
-  exists(string name | name = f.getQualifiedName() |
+  exists(string name | f.hasGlobalName(name) |
     (
       name = "gmtime" or
       name = "localtime" or
@@ -21,7 +21,7 @@ predicate potentiallyDangerousFunction(Function f, string message) {
     ) and
     message = "Call to " + name + " is potentially dangerous"
   ) or (
-    f.getQualifiedName() = "gets" and
+    f.hasGlobalName("gets") and
     message = "gets does not guard against buffer overflow"
   )
 }

cpp/ql/src/jsf/4.10 Classes/AV Rule 79.ql

@@ -21,7 +21,7 @@ predicate acquireExpr(Expr acquire, string kind) {
   exists(FunctionCall fc, Function f, string name |
     fc = acquire and
     f = fc.getTarget() and
-    name = f.getQualifiedName() and 
+    f.hasGlobalName(name) and 
     (
       (
         name = "fopen" and
@@ -47,7 +47,7 @@ predicate releaseExpr(Expr release, Expr resource, string kind) {
   exists(FunctionCall fc, Function f, string name |
     fc = release and
     f = fc.getTarget() and
-    name = f.getQualifiedName() and 
+    f.hasGlobalName(name) and 
     (
       (
         name = "fclose" and
@@ -252,7 +252,7 @@ pragma[noopt] predicate badRelease(Resource r, Expr acquire, Function functionCa
   )
 }
 
-Class qtObject() { result.getABaseClass*().getQualifiedName() = "QObject" }
+Class qtObject() { result.getABaseClass*().hasGlobalName("QObject") }
 PointerType qtObjectReference() { result.getBaseType() = qtObject() }
 Constructor qtParentConstructor() {
   exists(Parameter p |

cpp/ql/src/semmle/code/cpp/commons/Printf.qll

@@ -74,20 +74,6 @@ class UserDefinedFormattingFunction extends FormattingFunction {
   override int getFormatParameterIndex() { callsVariadicFormatter(this, result) }
 }
 
-/**
- * The Objective C method `stringWithFormat:`.
- */
-class NsstringStringWithFormat extends FormattingFunction {
-  NsstringStringWithFormat() {
-    getQualifiedName().matches("NSString%::+stringWithFormat:") or
-    getQualifiedName().matches("NSString%::+localizedStringWithFormat:")
-  }
-
-  override int getFormatParameterIndex() {
-    result = 0
-  }
-}
-
 /**
  * A call to one of the formatting functions.
  */