removed unnecessary getACall and fixed formatting

bananabr · bananabr · commit 64da2cec5048 · 2022-10-26T12:02:55.000-05:00
diff --git a/javascript/ql/src/experimental/Security/CWE-340/TokenBuiltFromUUID.ql b/javascript/ql/src/experimental/Security/CWE-340/TokenBuiltFromUUID.ql
@@ -18,8 +18,7 @@ import DataFlow::PathGraph
 class PredictableResultSource extends DataFlow::Node {
   PredictableResultSource() {
     exists(API::Node uuidCallRet |
-      uuidCallRet =
-        API::moduleImport("uuid").getMember(["v1", "v3", "v5"]).getACall().getReturn()
+      uuidCallRet = API::moduleImport("uuid").getMember(["v1", "v3", "v5"]).getReturn()
     |
       this = uuidCallRet.asSource()
     )

Original file line number	Diff line number	Diff line change
`@@ -18,8 +18,7 @@ import DataFlow::PathGraph`
`18`	`18`	`class PredictableResultSource extends DataFlow::Node {`
`19`	`19`	`PredictableResultSource() {`
`20`	`20`	`exists(API::Node uuidCallRet \|`
`21`		`- uuidCallRet =`
`22`		`- API::moduleImport("uuid").getMember(["v1", "v3", "v5"]).getACall().getReturn()`
	`21`	`+ uuidCallRet = API::moduleImport("uuid").getMember(["v1", "v3", "v5"]).getReturn()`
`23`	`22`	`\|`
`24`	`23`	`this = uuidCallRet.asSource()`
`25`	`24`	`)`