Skip to content

Commit 662736e

Browse files
committed
Fix compiler error after removing getLOp/getROp
1 parent 7233ffa commit 662736e

File tree

1 file changed

+3
-5
lines changed

1 file changed

+3
-5
lines changed

cpp/ql/src/experimental/semmle/code/cpp/rangeanalysis/extensions/ConstantBitwiseAndExprRange.qll

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -30,9 +30,9 @@ private class ConstantBitwiseAndExprRange extends SimpleRangeAnalysisExpr {
3030
r = this.(AssignAndExpr).getRValue()
3131
|
3232
// No operands can be negative constants
33-
not (evaluateConstantExpr(getLOp(this)) < 0 or evaluateConstantExpr(getROp(this)) < 0) and
33+
not (evaluateConstantExpr(l) < 0 or evaluateConstantExpr(r) < 0) and
3434
// At least one operand must be a non-negative constant
35-
(evaluateConstantExpr(getLOp(this)) >= 0 or evaluateConstantExpr(getROp(this)) >= 0)
35+
(evaluateConstantExpr(l) >= 0 or evaluateConstantExpr(r) >= 0)
3636
)
3737
}
3838

@@ -49,11 +49,9 @@ private class ConstantBitwiseAndExprRange extends SimpleRangeAnalysisExpr {
4949
override float getLowerBounds() {
5050
// If an operand can have negative values, the lower bound is unconstrained.
5151
// Otherwise, the lower bound is zero.
52-
exists(float lLower, float lUpper, float rLower, float rUpper |
52+
exists(float lLower, float rLower |
5353
lLower = getFullyConvertedLowerBounds(getLeftOperand()) and
54-
lUpper = getFullyConvertedUpperBounds(getLeftOperand()) and
5554
rLower = getFullyConvertedLowerBounds(getRightOperand()) and
56-
rUpper = getFullyConvertedUpperBounds(getRightOperand()) and
5755
(
5856
(lLower < 0 or rLower < 0) and
5957
result = exprMinVal(this)

0 commit comments

Comments
 (0)