File tree Expand file tree Collapse file tree 2 files changed +9
-9
lines changed
cpp/ql/test/query-tests/Likely Bugs/Leap Year
UncheckedLeapYearAfterYearModification Expand file tree Collapse file tree 2 files changed +9
-9
lines changed Original file line number Diff line number Diff line change @@ -171,7 +171,7 @@ void antipattern2()
171171
172172 // copy back to a FILETIME
173173 ft.dwLowDateTime = (DWORD)(qwLongTime & 0xFFFFFFFF ); // BAD
174- ft.dwHighDateTime = (DWORD)(qwLongTime >> 32 );
174+ ft.dwHighDateTime = (DWORD)(qwLongTime >> 32 ); // BAD
175175
176176 // convert back to SYSTEMTIME for display or other usage
177177 FileTimeToSystemTime (&ft, &st);
@@ -215,7 +215,7 @@ void checkedExample()
215215
216216 // copy back to a FILETIME
217217 ft.dwLowDateTime = (DWORD)(qwLongTime & 0xFFFFFFFF ); // GOOD [FALSE POSITIVE]
218- ft.dwHighDateTime = (DWORD)(qwLongTime >> 32 );
218+ ft.dwHighDateTime = (DWORD)(qwLongTime >> 32 ); // GOOD [FALSE POSITIVE]
219219
220220 // convert back to SYSTEMTIME for display or other usage
221221 if (FileTimeToSystemTime (&ft, &st) == 0 )
Original file line number Diff line number Diff line change @@ -445,7 +445,7 @@ void CorrectPattern_check4()
445445 if (fixDate (st.wDay , st.wMonth , st.wYear ))
446446 {
447447 // move back a day when landing on Feb 29 in an non-leap year
448- st.wDay = 28 ;
448+ st.wDay = 28 ; // GOOD [FALSE POSITIVE]
449449 }
450450
451451 // Safe to use
@@ -715,9 +715,9 @@ void modified3()
715715
716716 GetSystemTime (&st);
717717
718- st.wYear = st.wYear + 1 ;
718+ st.wYear = st.wYear + 1 ; // BAD
719719
720- SystemTimeToFileTime (&st, &ft); // BAD
720+ SystemTimeToFileTime (&st, &ft);
721721}
722722
723723void modified4 ()
@@ -728,9 +728,9 @@ void modified4()
728728
729729 GetSystemTime (&st);
730730
731- st.wYear ++;
732- st.wYear ++;
733- st.wYear ++;
731+ st.wYear ++; // BAD
732+ st.wYear ++; // BAD
733+ st.wYear ++; // BAD
734734
735- SystemTimeToFileTime (&st, &ft); // BAD
735+ SystemTimeToFileTime (&st, &ft);
736736}
You can’t perform that action at this time.
0 commit comments