C#/Ruby: Use a 'noinline' instead of a 'only_bind_into'.

Author: MathiasVP

csharp/ql/lib/semmle/code/cil/internal/SsaImplCommon.qll

@@ -156,6 +156,7 @@ private predicate dominatesPredecessor(BasicBlock bb1, BasicBlock bb2) {
 }
 
 /** Holds if `df` is in the dominance frontier of `bb`. */
+pragma[noinline]
 private predicate inDominanceFrontier(BasicBlock bb, BasicBlock df) {
   dominatesPredecessor(bb, df) and
   not strictlyDominates(bb, df)
@@ -169,7 +170,7 @@ pragma[noinline]
 private predicate inDefDominanceFrontier(BasicBlock bb, SourceVariable v) {
   exists(BasicBlock defbb, Definition def |
     def.definesAt(v, defbb, _) and
-    inDominanceFrontier(pragma[only_bind_into](defbb), bb)
+    inDominanceFrontier(defbb, bb)
   )
 }
 

csharp/ql/lib/semmle/code/csharp/controlflow/internal/pressa/SsaImplCommon.qll

@@ -156,6 +156,7 @@ private predicate dominatesPredecessor(BasicBlock bb1, BasicBlock bb2) {
 }
 
 /** Holds if `df` is in the dominance frontier of `bb`. */
+pragma[noinline]
 private predicate inDominanceFrontier(BasicBlock bb, BasicBlock df) {
   dominatesPredecessor(bb, df) and
   not strictlyDominates(bb, df)
@@ -169,7 +170,7 @@ pragma[noinline]
 private predicate inDefDominanceFrontier(BasicBlock bb, SourceVariable v) {
   exists(BasicBlock defbb, Definition def |
     def.definesAt(v, defbb, _) and
-    inDominanceFrontier(pragma[only_bind_into](defbb), bb)
+    inDominanceFrontier(defbb, bb)
   )
 }
 

csharp/ql/lib/semmle/code/csharp/dataflow/internal/SsaImplCommon.qll

@@ -156,6 +156,7 @@ private predicate dominatesPredecessor(BasicBlock bb1, BasicBlock bb2) {
 }
 
 /** Holds if `df` is in the dominance frontier of `bb`. */
+pragma[noinline]
 private predicate inDominanceFrontier(BasicBlock bb, BasicBlock df) {
   dominatesPredecessor(bb, df) and
   not strictlyDominates(bb, df)
@@ -169,7 +170,7 @@ pragma[noinline]
 private predicate inDefDominanceFrontier(BasicBlock bb, SourceVariable v) {
   exists(BasicBlock defbb, Definition def |
     def.definesAt(v, defbb, _) and
-    inDominanceFrontier(pragma[only_bind_into](defbb), bb)
+    inDominanceFrontier(defbb, bb)
   )
 }
 

csharp/ql/lib/semmle/code/csharp/dataflow/internal/basessa/SsaImplCommon.qll

@@ -156,6 +156,7 @@ private predicate dominatesPredecessor(BasicBlock bb1, BasicBlock bb2) {
 }
 
 /** Holds if `df` is in the dominance frontier of `bb`. */
+pragma[noinline]
 private predicate inDominanceFrontier(BasicBlock bb, BasicBlock df) {
   dominatesPredecessor(bb, df) and
   not strictlyDominates(bb, df)
@@ -169,7 +170,7 @@ pragma[noinline]
 private predicate inDefDominanceFrontier(BasicBlock bb, SourceVariable v) {
   exists(BasicBlock defbb, Definition def |
     def.definesAt(v, defbb, _) and
-    inDominanceFrontier(pragma[only_bind_into](defbb), bb)
+    inDominanceFrontier(defbb, bb)
   )
 }
 

ruby/ql/lib/codeql/ruby/dataflow/internal/SsaImplCommon.qll

@@ -156,6 +156,7 @@ private predicate dominatesPredecessor(BasicBlock bb1, BasicBlock bb2) {
 }
 
 /** Holds if `df` is in the dominance frontier of `bb`. */
+pragma[noinline]
 private predicate inDominanceFrontier(BasicBlock bb, BasicBlock df) {
   dominatesPredecessor(bb, df) and
   not strictlyDominates(bb, df)
@@ -169,7 +170,7 @@ pragma[noinline]
 private predicate inDefDominanceFrontier(BasicBlock bb, SourceVariable v) {
   exists(BasicBlock defbb, Definition def |
     def.definesAt(v, defbb, _) and
-    inDominanceFrontier(pragma[only_bind_into](defbb), bb)
+    inDominanceFrontier(defbb, bb)
   )
 }