Skip to content

Commit 6a4dbfc

Browse files
committed
Address review comment
1 parent 9a7746e commit 6a4dbfc

File tree

2 files changed

+10
-10
lines changed

2 files changed

+10
-10
lines changed

csharp/ql/src/semmle/code/csharp/dataflow/SSA.qll

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -119,11 +119,11 @@ module Ssa {
119119
ad.getAControlFlowNode() = bb.getNode(i)
120120
and
121121
// In cases like `(x, x) = (0, 1)`, we discard the first (dead) definition of `x`
122-
not exists(TupleAssignmentDefinition tdef, TupleAssignmentDefinition other |
123-
tdef = ad |
124-
other.getAssignment() = tdef.getAssignment() and
125-
other.getEvaluationOrder() > tdef.getEvaluationOrder() and
126-
other = v.getADefinition()
122+
not exists(TupleAssignmentDefinition first, TupleAssignmentDefinition second |
123+
first = ad |
124+
second.getAssignment() = first.getAssignment() and
125+
second.getEvaluationOrder() > first.getEvaluationOrder() and
126+
second = v.getADefinition()
127127
)
128128
and
129129
// In cases like `M(out x, out x)`, there is no inherent evaluation order, so we

csharp/ql/src/semmle/code/csharp/dataflow/internal/BaseSSA.qll

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -27,11 +27,11 @@ module BaseSsa {
2727
bb.getNode(i) = def.getAControlFlowNode() and
2828
v = def.getTarget() and
2929
// In cases like `(x, x) = (0, 1)`, we discard the first (dead) definition of `x`
30-
not exists(TupleAssignmentDefinition tdef, TupleAssignmentDefinition other |
31-
tdef = def |
32-
other.getAssignment() = tdef.getAssignment() and
33-
other.getEvaluationOrder() > tdef.getEvaluationOrder() and
34-
other.getTarget() = v
30+
not exists(TupleAssignmentDefinition first, TupleAssignmentDefinition second |
31+
first = def |
32+
second.getAssignment() = first.getAssignment() and
33+
second.getEvaluationOrder() > first.getEvaluationOrder() and
34+
second.getTarget() = v
3535
)
3636
}
3737

0 commit comments

Comments
 (0)