Skip to content

Commit 6c96a8d

Browse files
committed
Java: Accept test changes
Note: the results in `partial` have regressed and will need to be fixed in a follow-up commit.
1 parent 9f0f2f7 commit 6c96a8d

File tree

4 files changed

+5
-17
lines changed

4 files changed

+5
-17
lines changed

java/ql/test/library-tests/dataflow/fields/B.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,14 +5,14 @@ public void f1() {
55
Box1 b1 = new Box1(e, null);
66
Box2 b2 = new Box2(b1);
77
sink(b2.box1.elem1); // flow
8-
sink(b2.box1.elem2); // FP due to flow in f2 below
8+
sink(b2.box1.elem2); // no flow
99
}
1010

1111
public void f2() {
1212
Elem e = new Elem();
1313
Box1 b1 = new Box1(null, e);
1414
Box2 b2 = new Box2(b1);
15-
sink(b2.box1.elem1); // FP due to flow in f1 above
15+
sink(b2.box1.elem1); // no flow
1616
sink(b2.box1.elem2); // flow
1717
}
1818

java/ql/test/library-tests/dataflow/fields/flow.expected

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,6 @@
1212
| A.java:94:11:94:17 | new B(...) | A.java:100:10:100:26 | l3.next.next.head |
1313
| A.java:94:11:94:17 | new B(...) | A.java:103:12:103:17 | l.head |
1414
| B.java:4:14:4:23 | new Elem(...) | B.java:7:10:7:22 | b2.box1.elem1 |
15-
| B.java:4:14:4:23 | new Elem(...) | B.java:8:10:8:22 | b2.box1.elem2 |
16-
| B.java:12:14:12:23 | new Elem(...) | B.java:15:10:15:22 | b2.box1.elem1 |
1715
| B.java:12:14:12:23 | new Elem(...) | B.java:16:10:16:22 | b2.box1.elem2 |
1816
| C.java:3:21:3:30 | new Elem(...) | C.java:18:10:18:11 | s1 |
1917
| C.java:4:27:4:36 | new Elem(...) | C.java:19:10:19:11 | s2 |
Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,4 @@
11
edges
2-
| A.java:12:5:12:5 | b [post update] [elem, ... (1)] | A.java:13:12:13:12 | b [elem, ... (1)] |
3-
| A.java:12:14:12:18 | src(...) [Object] | A.java:12:5:12:5 | b [post update] [elem, ... (1)] |
42
| A.java:12:14:12:18 | src(...) [Object] | A.java:12:5:12:18 | ...=... [Object] |
5-
| A.java:13:12:13:12 | b [elem, ... (1)] | A.java:17:13:17:16 | f1(...) [elem, ... (1)] |
6-
| A.java:17:13:17:16 | f1(...) [elem, ... (1)] | A.java:18:8:18:8 | b [elem, ... (1)] |
7-
| A.java:18:8:18:8 | b [elem, ... (1)] | A.java:21:11:21:15 | b [elem, ... (1)] |
83
#select
9-
| 0 | A.java:12:5:12:5 | b [post update] [elem, ... (1)] |
104
| 0 | A.java:12:5:12:18 | ...=... [Object] |
11-
| 0 | A.java:13:12:13:12 | b [elem, ... (1)] |
12-
| 1 | A.java:17:13:17:16 | f1(...) [elem, ... (1)] |
13-
| 1 | A.java:18:8:18:8 | b [elem, ... (1)] |
14-
| 2 | A.java:21:11:21:15 | b [elem, ... (1)] |

java/ql/test/query-tests/security/CWE-190/semmle/tests/ArithmeticTaintedLocal.expected

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,9 @@ edges
88
| ArithmeticTainted.java:17:46:17:54 | System.in [InputStream] | ArithmeticTainted.java:119:10:119:13 | data [Number] |
99
| ArithmeticTainted.java:17:46:17:54 | System.in [InputStream] | ArithmeticTainted.java:120:10:120:13 | data [Number] |
1010
| ArithmeticTainted.java:17:46:17:54 | System.in [InputStream] | ArithmeticTainted.java:121:10:121:13 | data [Number] |
11-
| ArithmeticTainted.java:64:4:64:10 | tainted [post update] [dat, ... (1)] | ArithmeticTainted.java:66:18:66:24 | tainted [dat, ... (1)] |
12-
| ArithmeticTainted.java:64:20:64:23 | data [Number] | ArithmeticTainted.java:64:4:64:10 | tainted [post update] [dat, ... (1)] |
13-
| ArithmeticTainted.java:66:18:66:24 | tainted [dat, ... (1)] | ArithmeticTainted.java:66:18:66:34 | getData(...) [Number] |
11+
| ArithmeticTainted.java:64:4:64:10 | tainted [post update] [dat : Number] | ArithmeticTainted.java:66:18:66:24 | tainted [dat : Number] |
12+
| ArithmeticTainted.java:64:20:64:23 | data [Number] | ArithmeticTainted.java:64:4:64:10 | tainted [post update] [dat : Number] |
13+
| ArithmeticTainted.java:66:18:66:24 | tainted [dat : Number] | ArithmeticTainted.java:66:18:66:34 | getData(...) [Number] |
1414
| ArithmeticTainted.java:66:18:66:34 | getData(...) [Number] | ArithmeticTainted.java:71:17:71:23 | herring |
1515
| ArithmeticTainted.java:118:9:118:12 | data [Number] | ArithmeticTainted.java:125:26:125:33 | data [Number] |
1616
| ArithmeticTainted.java:119:10:119:13 | data [Number] | ArithmeticTainted.java:129:27:129:34 | data [Number] |

0 commit comments

Comments
 (0)