Merge pull request #2164 from hmakholm/suites

p0 · web-flow · commit 72de1b25ab89 · 2019-10-22T16:35:19.000+01:00
Add some new-style suite definitions
diff --git a/cpp/ql/src/codeql-suites/cpp-lgtm-full.qls b/cpp/ql/src/codeql-suites/cpp-lgtm-full.qls
@@ -0,0 +1,14 @@
+- description: Standard LGTM queries for C/C++, including ones not displayed by default
+- qlpack: codeql-cpp
+- apply: lgtm-selectors.yml
+  from: codeql-suite-helpers
+# These queries are infeasible to compute on large projects:
+- exclude:
+    query path:
+      - Security/CWE/CWE-497/ExposedSystemData.ql
+      - Critical/DescriptorMayNotBeClosed.ql
+      - Critical/DescriptorNeverClosed.ql
+      - Critical/FileMayNotBeClosed.ql
+      - Critical/FileNeverClosed.ql
+      - Critical/MemoryMayNotBeFreed.ql
+      - Critical/MemoryNeverFreed.ql
diff --git a/cpp/ql/src/codeql-suites/cpp-lgtm.qls b/cpp/ql/src/codeql-suites/cpp-lgtm.qls
@@ -0,0 +1,4 @@
+- description: Standard LGTM queries for C/C++
+- apply: codeql-suites/cpp-lgtm-full.qls
+- apply: lgtm-displayed-only.yml
+  from: codeql-suite-helpers
diff --git a/cpp/ql/src/qlpack.json b/cpp/ql/src/qlpack.json
@@ -1,5 +1,6 @@
 {
     "name": "codeql-cpp",
     "version": "0.0.0",
-    "dbscheme": "semmlecode.cpp.dbscheme"
+    "dbscheme": "semmlecode.cpp.dbscheme",
+    "suites": "codeql-suites"
 }
diff --git a/csharp/ql/src/codeql-suites/csharp-lgtm-full.qls b/csharp/ql/src/codeql-suites/csharp-lgtm-full.qls
@@ -0,0 +1,4 @@
+- description: Standard LGTM queries for C#, including ones not displayed by default
+- qlpack: codeql-csharp
+- apply: lgtm-selectors.yml
+  from: codeql-suite-helpers
diff --git a/csharp/ql/src/codeql-suites/csharp-lgtm.qls b/csharp/ql/src/codeql-suites/csharp-lgtm.qls
@@ -0,0 +1,4 @@
+- description: Standard LGTM queries for C#
+- apply: codeql-suites/csharp-lgtm-full.qls
+- apply: lgtm-displayed-only.yml
+  from: codeql-suite-helpers
diff --git a/csharp/ql/src/qlpack.json b/csharp/ql/src/qlpack.json
@@ -1,5 +1,6 @@
 {
     "name": "codeql-csharp",
     "version": "0.0.0",
-    "dbscheme": "semmlecode.csharp.dbscheme"
+    "dbscheme": "semmlecode.csharp.dbscheme",
+    "suites": "codeql-suites"
 }
diff --git a/java/ql/src/codeql-suites/java-lgtm-full.qls b/java/ql/src/codeql-suites/java-lgtm-full.qls
@@ -0,0 +1,4 @@
+- description: Standard LGTM queries for Java, including ones not displayed by default
+- qlpack: codeql-java
+- apply: lgtm-selectors.yml
+  from: codeql-suite-helpers
diff --git a/java/ql/src/codeql-suites/java-lgtm.qls b/java/ql/src/codeql-suites/java-lgtm.qls
@@ -0,0 +1,4 @@
+- description: Standard LGTM queries for Java
+- apply: codeql-suites/java-lgtm-full.qls
+- apply: lgtm-displayed-only.yml
+  from: codeql-suite-helpers
diff --git a/java/ql/src/qlpack.json b/java/ql/src/qlpack.json
@@ -1,5 +1,6 @@
 {
     "name": "codeql-java",
     "version": "0.0.0",
-    "dbscheme": "config/semmlecode.dbscheme"
+    "dbscheme": "config/semmlecode.dbscheme",
+    "suites": "codeql-suites"
 }
diff --git a/javascript/ql/src/codeql-suites/javascript-lgtm-full.qls b/javascript/ql/src/codeql-suites/javascript-lgtm-full.qls
@@ -0,0 +1,4 @@
+- description: Standard LGTM queries for JavaScript, including ones not displayed by default
+- qlpack: codeql-javascript
+- apply: lgtm-selectors.yml
+  from: codeql-suite-helpers
diff --git a/javascript/ql/src/codeql-suites/javascript-lgtm.qls b/javascript/ql/src/codeql-suites/javascript-lgtm.qls
@@ -0,0 +1,4 @@
+- description: Standard LGTM queries for JavaScript
+- apply: codeql-suites/javascript-lgtm-full.qls
+- apply: lgtm-displayed-only.yml
+  from: codeql-suite-helpers
diff --git a/javascript/ql/src/qlpack.json b/javascript/ql/src/qlpack.json
@@ -1,5 +1,6 @@
 {
     "name": "codeql-javascript",
     "version": "0.0.0",
-    "dbscheme": "semmlecode.javascript.dbscheme"
+    "dbscheme": "semmlecode.javascript.dbscheme",
+    "suites": "codeql-suites"
 }
diff --git a/misc/suite-helpers/lgtm-displayed-only.yml b/misc/suite-helpers/lgtm-displayed-only.yml
@@ -0,0 +1,8 @@
+- description: Selectors for excluding queries that LGTM doesn't display by default
+- exclude:
+    kind: problem
+    precision: medium
+- exclude:
+    kind: problem
+    precision: high
+    problem.severity: recommendation
diff --git a/misc/suite-helpers/lgtm-selectors.yml b/misc/suite-helpers/lgtm-selectors.yml
@@ -0,0 +1,19 @@
+- description: Selectors for selecting the LGTM-relevant queries for a language
+- include:
+    kind: problem
+    precision:
+    - high
+    - very high
+- include:
+    kind: problem
+    precision: medium
+    problem.severity:
+      - error
+      - warning
+- include:
+    kind:
+      - definitions
+      - alert-suppression
+      - file-classifier
+- exclude:
+    deprecated: //
diff --git a/misc/suite-helpers/qlpack.json b/misc/suite-helpers/qlpack.json
@@ -0,0 +1,4 @@
+{
+    "name" : "codeql-suite-helpers",
+    "version" : "0.0.0"
+}
diff --git a/python/ql/src/codeql-suites/python-lgtm-full.qls b/python/ql/src/codeql-suites/python-lgtm-full.qls
@@ -0,0 +1,4 @@
+- description: Standard LGTM queries for Python, including ones not displayed by default
+- qlpack: codeql-python
+- apply: lgtm-selectors.yml
+  from: codeql-suite-helpers
diff --git a/python/ql/src/codeql-suites/python-lgtm.qls b/python/ql/src/codeql-suites/python-lgtm.qls
@@ -0,0 +1,4 @@
+- description: Standard LGTM queries for Python
+- apply: codeql-suites/python-lgtm-full.qls
+- apply: lgtm-displayed-only.yml
+  from: codeql-suite-helpers
diff --git a/python/ql/src/qlpack.json b/python/ql/src/qlpack.json
@@ -1,5 +1,6 @@
 {
     "name": "codeql-python",
     "version": "0.0.0",
-    "dbscheme": "semmlecode.python.dbscheme"
+    "dbscheme": "semmlecode.python.dbscheme",
+    "suites": "codeql-suites"
 }

Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "codeql-cpp",`
`3`	`3`	`"version": "0.0.0",`
`4`		`- "dbscheme": "semmlecode.cpp.dbscheme"`
	`4`	`+ "dbscheme": "semmlecode.cpp.dbscheme",`
	`5`	`+ "suites": "codeql-suites"`
`5`	`6`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "codeql-csharp",`
`3`	`3`	`"version": "0.0.0",`
`4`		`- "dbscheme": "semmlecode.csharp.dbscheme"`
	`4`	`+ "dbscheme": "semmlecode.csharp.dbscheme",`
	`5`	`+ "suites": "codeql-suites"`
`5`	`6`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "codeql-java",`
`3`	`3`	`"version": "0.0.0",`
`4`		`- "dbscheme": "config/semmlecode.dbscheme"`
	`4`	`+ "dbscheme": "config/semmlecode.dbscheme",`
	`5`	`+ "suites": "codeql-suites"`
`5`	`6`	`}`