Skip to content

Commit 75d996a

Browse files
committed
make promisify smaller
1 parent bce06d3 commit 75d996a

File tree

1 file changed

+6
-4
lines changed
  • javascript/ql/src/semmle/javascript/frameworks

1 file changed

+6
-4
lines changed

javascript/ql/src/semmle/javascript/frameworks/NoSQL.qll

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -816,17 +816,19 @@ private module Redis {
816816
exists(string method, int argIndex |
817817
QuerySignatures::argumentIsAmbiguousKey(method, argIndex)
818818
|
819-
this = promisify(redis().getMember(method)).getACall().getArgument(argIndex).asExpr()
819+
this =
820+
[promisify(redis().getMember(method)), redis().getMember(method)]
821+
.getACall()
822+
.getArgument(argIndex)
823+
.asExpr()
820824
)
821825
}
822826
}
823827

824828
/**
825-
* Gets a possibly promisified version of `method`.
829+
* Gets a promisified version of `method`.
826830
*/
827831
private API::Node promisify(API::Node method) {
828-
result = method
829-
or
830832
exists(API::Node promisify |
831833
promisify = API::moduleImport(["util", "bluebird"]).getMember("promisify").getReturn() and
832834
method

0 commit comments

Comments
 (0)