Skip to content

Commit 75ef377

Browse files
Replace Unicode apostrophe with ANSI single quote
1 parent 5ccc1a3 commit 75ef377

File tree

3 files changed

+9
-6
lines changed

3 files changed

+9
-6
lines changed

.gitignore

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,3 +12,6 @@
1212
/.vs/ql/v15/Browse.VC.opendb
1313
/.vs/ql/v15/Browse.VC.db
1414
/.vs/ProjectSettings.json
15+
/.vs/ql5/v15/Browse.VC.opendb
16+
/.vs/ql5/v15/Browse.VC.db
17+
/.vs/ql5/v15/.suo

cpp/ql/src/Security/CWE/CWE-732/UnsafeDaclSecurityDescriptor.ql

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
/**
2-
* @name Setting a SECURITY_DESCRIPTORs DACL to NULL
3-
* @description Setting a SECURITY_DESCRIPTORs DACL to NULL will result in an unprotected object.
2+
* @name Setting a SECURITY_DESCRIPTOR's DACL to NULL
3+
* @description Setting a SECURITY_DESCRIPTOR's DACL to NULL will result in an unprotected object.
44
* If the DACL that belongs to the security descriptor of an object is set to NULL, a null DACL is created.
55
* A null DACL grants full access to any user who requests it;
66
* normal security checking is not performed with respect to the object.
@@ -49,12 +49,12 @@ class SetSecurityDescriptorDaclFunctionConfiguration extends DataFlow::Configura
4949

5050
from SetSecurityDescriptorDaclFunctionCall call, string message
5151
where exists( NullValue nullExpr |
52-
message = "Setting a SECURITY_DESCRIPTORs DACL to NULL will result in an unprotected object." |
52+
message = "Setting a SECURITY_DESCRIPTOR's DACL to NULL will result in an unprotected object." |
5353
call.getArgument(1).getValue().toInt() != 0
5454
and call.getArgument(2) = nullExpr
5555
) or exists( Expr constassign, VariableAccess var,
5656
SetSecurityDescriptorDaclFunctionConfiguration config |
57-
message = "Setting a SECURITY_DESCRIPTORs DACL using variable " + var + " that is set to NULL will result in an unprotected object." |
57+
message = "Setting a SECURITY_DESCRIPTOR's DACL using variable " + var + " that is set to NULL will result in an unprotected object." |
5858
var = call.getArgument(2)
5959
and config.hasFlow(DataFlow::exprNode(constassign), DataFlow::exprNode(var))
6060
)
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
1-
| UnsafeDaclSecurityDescriptor.cpp:69:6:69:30 | call to SetSecurityDescriptorDacl | Setting a SECURITY_DESCRIPTOR\u2019s DACL to NULL will result in an unprotected object. |
2-
| UnsafeDaclSecurityDescriptor.cpp:75:6:75:30 | call to SetSecurityDescriptorDacl | Setting a SECURITY_DESCRIPTOR\u2019s DACL using variable pDacl that is set to NULL will result in an unprotected object. |
1+
| UnsafeDaclSecurityDescriptor.cpp:69:6:69:30 | call to SetSecurityDescriptorDacl | Setting a SECURITY_DESCRIPTOR's DACL to NULL will result in an unprotected object. |
2+
| UnsafeDaclSecurityDescriptor.cpp:75:6:75:30 | call to SetSecurityDescriptorDacl | Setting a SECURITY_DESCRIPTOR's DACL using variable pDacl that is set to NULL will result in an unprotected object. |

0 commit comments

Comments
 (0)