Skip to content

Commit 7790d4b

Browse files
committed
JS: Make getALocalValue overriders include super
1 parent 2006826 commit 7790d4b

File tree

1 file changed

+10
-2
lines changed

1 file changed

+10
-2
lines changed

javascript/ql/src/semmle/javascript/dataflow/internal/VariableTypeInference.qll

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -637,7 +637,11 @@ private class ReflectiveVarFlow extends DataFlow::AnalyzedValueNode {
637637
)
638638
}
639639

640-
override AbstractValue getALocalValue() { result = TIndefiniteAbstractValue("eval") }
640+
override AbstractValue getALocalValue() {
641+
result = TIndefiniteAbstractValue("eval")
642+
or
643+
result = AnalyzedValueNode.super.getALocalValue()
644+
}
641645
}
642646

643647
/**
@@ -649,7 +653,11 @@ private class ReflectiveVarFlow extends DataFlow::AnalyzedValueNode {
649653
private class NamespaceExportVarFlow extends DataFlow::AnalyzedValueNode {
650654
NamespaceExportVarFlow() { astNode.(VarAccess).getVariable().isNamespaceExport() }
651655

652-
override AbstractValue getALocalValue() { result = TIndefiniteAbstractValue("namespace") }
656+
override AbstractValue getALocalValue() {
657+
result = TIndefiniteAbstractValue("namespace")
658+
or
659+
result = AnalyzedValueNode.super.getALocalValue()
660+
}
653661
}
654662

655663
/**

0 commit comments

Comments
 (0)