Fixing typos & ID.

raulgarciamsft · raulgarciamsft · commit 783be15a4593 · 2018-09-21T11:14:14.000-07:00
NOTE: There is an ongoing discussion on the proper CWE we should use
diff --git a/cpp/ql/src/Security/CWE/CWE-704/IncorrectTypeConversion.ql b/cpp/ql/src/Security/CWE/CWE-704/IncorrectTypeConversion.ql
@@ -4,7 +4,7 @@
  *              Boolean types indicate success by a non-zero value, whereas success (S_OK) in HRESULT is indicated by a value of 0. 
  *              Casting an HRESULT to/from a Boolean type and then using it in a test expression will yield an incorrect result.
  * @kind problem
- * @id cpp/incorrect-type-conversion
+ * @id cpp/hresult-to-boolean-conversion
  * @problem.severity error
  * @precision high
  * @tags security
diff --git a/cpp/ql/test/query-tests/Security/CWE/CWE-704/IncorrectTypeConversion.cpp b/cpp/ql/test/query-tests/Security/CWE/CWE-704/IncorrectTypeConversion.cpp
@@ -65,7 +65,7 @@ void IncorrectTypeConversionTest() {
 	}
 
 	hr = S_FALSE;
-	if (hr) // Should fail
+	if (hr) // BUG
 	{
 		// ...
 	}
diff --git a/cpp/ql/test/query-tests/Security/CWE/CWE-704/IncorrectTypeConversion.qlref b/cpp/ql/test/query-tests/Security/CWE/CWE-704/IncorrectTypeConversion.qlref
@@ -1 +1 @@
-Security/CWE/CWE-704/incorrectTypeConversion.ql
+Security/CWE/CWE-704/IncorrectTypeConversion.ql

Original file line number	Diff line number	Diff line change
`@@ -65,7 +65,7 @@ void IncorrectTypeConversionTest() {`
`65`	`65`	`}`
`66`	`66`
`67`	`67`	`hr = S_FALSE;`
`68`		`- if (hr) // Should fail`
	`68`	`+ if (hr) // BUG`
`69`	`69`	`{`
`70`	`70`	`// ...`
`71`	`71`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1 +1 @@`
`1`		`-Security/CWE/CWE-704/incorrectTypeConversion.ql`
	`1`	`+Security/CWE/CWE-704/IncorrectTypeConversion.ql`