Merge pull request #734 from xiemaisi/js/remove-deprecated

Approved by esben-semmle

Author: semmle-qlci

change-notes/1.20/analysis-javascript.md

@@ -36,3 +36,4 @@
 
 * `DataFlow::SourceNode` is no longer an abstract class; to add new source nodes, extend `DataFlow::SourceNode::Range` instead.
 * Subclasses of `DataFlow::PropRead` are no longer automatically made source nodes; you now need to additionally define a corresponding subclass of `DataFlow::SourceNode::Range` to achieve this.
+* The deprecated libraries `semmle.javascript.DataFlow` and `semmle.javascript.dataflow.CallGraph` have been removed; they are both superseded by `semmle.javascript.dataflow.DataFlow`.

javascript/ql/src/javascript.qll

@@ -11,7 +11,6 @@ import semmle.javascript.Classes
 import semmle.javascript.Comments
 import semmle.javascript.Concepts
 import semmle.javascript.Constants
-import semmle.javascript.DataFlow
 import semmle.javascript.DefUse
 import semmle.javascript.DOM
 import semmle.javascript.EmailClients
@@ -49,7 +48,6 @@ import semmle.javascript.Util
 import semmle.javascript.Variables
 import semmle.javascript.XML
 import semmle.javascript.YAML
-import semmle.javascript.dataflow.CallGraph
 import semmle.javascript.dataflow.DataFlow
 import semmle.javascript.dataflow.TaintTracking
 import semmle.javascript.dataflow.TypeInference

javascript/ql/src/semmle/javascript/AMD.qll

@@ -51,14 +51,6 @@ class AMDModuleDefinition extends CallExpr {
     result = getARequireCall().getAnArgument()
   }
 
-  /**
-   * DEPRECATED: Use `getFactoryNode` instead.
-   *
-   * Gets the factory expression of this module definition,
-   * which may be a function or a literal.
-   */
-  deprecated Expr getFactoryExpr() { result = getFactoryNode().asExpr() }
-
   /**
    * Gets a data flow node containing the factory value of this module definition.
    */

javascript/ql/src/semmle/javascript/CanonicalNames.qll

@@ -221,13 +221,6 @@ class TypeName extends CanonicalName {
    */
   TypeReference getATypeReference() { result.getTypeName() = this }
 
-  /**
-   * DEPRECATED. Use `getRelativeName()` or `hasQualifiedName()` instead.
-   *
-   * Gets the qualified name without the root.
-   */
-  deprecated string getQualifiedName() { result = getRelativeName() }
-
   /**
    * Gets a type named in the `extends` or `implements` clause of this type.
    */
@@ -265,13 +258,6 @@ class Namespace extends CanonicalName {
    */
   NamespaceAccess getAnAccess() { result.getNamespace() = this }
 
-  /**
-   * DEPRECATED. Use `getRelativeName()` or `hasQualifiedName()` instead.
-   *
-   * Gets the qualified name without the root.
-   */
-  deprecated string getQualifiedName() { result = getRelativeName() }
-
   /** Gets a namespace nested in this one. */
   Namespace getNamespaceMember(string name) {
     result.getParent() = this and

javascript/ql/src/semmle/javascript/Comments.qll

@@ -44,15 +44,6 @@ class HtmlCommentStart extends @htmlcommentstart, HtmlLineComment { }
 /** An HTML comment end token interpreted as a line comment. */
 class HtmlCommentEnd extends @htmlcommentend, HtmlLineComment { }
 
-/** DERECATED: Use `HtmlLineComment` instead. */
-deprecated class HTMLComment = HtmlLineComment;
-
-/** DERECATED: Use `HtmlCommentStart` instead. */
-deprecated class HTMLCommentStart = HtmlCommentStart;
-
-/** DERECATED: Use `HtmlCommentEnd` instead. */
-deprecated class HTMLCommentEnd = HtmlCommentEnd;
-
 /** A `//` comment. */
 class SlashSlashComment extends @slashslashcomment, LineComment { }