C++: An empty models-as-data namespace / type is not 'dubious' in CPP.

Author: geoffw0

cpp/ql/lib/semmle/code/cpp/dataflow/ExternalFlow.qll

@@ -330,10 +330,10 @@ module CsvValidation {
       or
       summaryModel(namespace, type, _, name, signature, ext, _, _, _, _) and pred = "summary"
     |
-      not namespace.regexpMatch("[a-zA-Z0-9_\\.]+") and
+      not namespace.regexpMatch("[a-zA-Z0-9_\\.]*") and
       result = "Dubious namespace \"" + namespace + "\" in " + pred + " model."
       or
-      not type.regexpMatch("[a-zA-Z0-9_<>,\\+]+") and
+      not type.regexpMatch("[a-zA-Z0-9_<>,\\+]*") and
       result = "Dubious type \"" + type + "\" in " + pred + " model."
       or
       not name.regexpMatch("[a-zA-Z0-9_<>,]*") and

cpp/ql/test/library-tests/dataflow/external-models/validatemodels.expected

@@ -1,10 +1,4 @@
-| Dubious namespace "" in sink model. |
-| Dubious namespace "" in source model. |
-| Dubious namespace "" in summary model. |
 | Dubious namespace "boost::asio" in sink model. |
 | Dubious namespace "boost::asio" in source model. |
 | Dubious namespace "boost::asio" in summary model. |
-| Dubious type "" in sink model. |
-| Dubious type "" in source model. |
-| Dubious type "" in summary model. |
 | Invalid kind "remote-sink" in sink model. |