Fix bug in regex

owen-mc · owen-mc · commit 7d11fc2c7db6 · 2024-06-26T05:01:09.000+01:00
I accidentally included a `$` at the end, so it only matched a major
version suffix at the end of the package path.
diff --git a/go/ql/lib/semmle/go/Packages.qll b/go/ql/lib/semmle/go/Packages.qll
@@ -23,7 +23,7 @@ class Package extends @package {
    * removed.
    */
   string getPathWithoutMajorVersionSuffix() {
-    result = this.getPath().regexpReplaceAll("[./]v\\d+$", "")
+    result = this.getPath().regexpReplaceAll("[./]v\\d+", "")
   }
 
   /** Gets the scope of this package. */

Original file line number	Diff line number	Diff line change
`@@ -23,7 +23,7 @@ class Package extends @package {`
`23`	`23`	`* removed.`
`24`	`24`	`*/`
`25`	`25`	`string getPathWithoutMajorVersionSuffix() {`
`26`		`- result = this.getPath().regexpReplaceAll("[./]v\\d+$", "")`
	`26`	`+ result = this.getPath().regexpReplaceAll("[./]v\\d+", "")`
`27`	`27`	`}`
`28`	`28`
`29`	`29`	`/** Gets the scope of this package. */`