Merge pull request #21204 from paldepind/rust/assoc-tp-fix

paldepind · web-flow · commit 7d34f6e26257 · 2026-01-22T13:46:09.000+01:00
Rust: Remove mistakenly included inherited associated types
diff --git a/rust/ql/lib/codeql/rust/internal/typeinference/TypeInference.qll b/rust/ql/lib/codeql/rust/internal/typeinference/TypeInference.qll
@@ -3811,12 +3811,12 @@ private module ForIterableSatisfiesConstraintInput implements
 
 pragma[nomagic]
 private AssociatedTypeTypeParameter getIteratorItemTypeParameter() {
-  result.getTypeAlias() = any(IteratorTrait t).getItemType()
+  result = getAssociatedTypeTypeParameter(any(IteratorTrait t).getItemType())
 }
 
 pragma[nomagic]
 private AssociatedTypeTypeParameter getIntoIteratorItemTypeParameter() {
-  result.getTypeAlias() = any(IntoIteratorTrait t).getItemType()
+  result = getAssociatedTypeTypeParameter(any(IntoIteratorTrait t).getItemType())
 }
 
 pragma[nomagic]

Original file line number	Diff line number	Diff line change
`@@ -3811,12 +3811,12 @@ private module ForIterableSatisfiesConstraintInput implements`
`3811`	`3811`
`3812`	`3812`	`pragma[nomagic]`
`3813`	`3813`	`private AssociatedTypeTypeParameter getIteratorItemTypeParameter() {`
`3814`		`- result.getTypeAlias() = any(IteratorTrait t).getItemType()`
	`3814`	`+ result = getAssociatedTypeTypeParameter(any(IteratorTrait t).getItemType())`
`3815`	`3815`	`}`
`3816`	`3816`
`3817`	`3817`	`pragma[nomagic]`
`3818`	`3818`	`private AssociatedTypeTypeParameter getIntoIteratorItemTypeParameter() {`
`3819`		`- result.getTypeAlias() = any(IntoIteratorTrait t).getItemType()`
	`3819`	`+ result = getAssociatedTypeTypeParameter(any(IntoIteratorTrait t).getItemType())`
`3820`	`3820`	`}`
`3821`	`3821`
`3822`	`3822`	`pragma[nomagic]`