C++: Improve make_pair in stl.h (jbj solution).

Author: geoffw0

cpp/ql/test/library-tests/dataflow/taint-tests/stl.h

@@ -324,8 +324,7 @@ namespace std {
 
 		void swap(pair& p) /*noexcept(...)*/;
 	};
-
-	template<class T1, class T2> constexpr pair<T1, T2> make_pair(T1&&, T2&&);
+	template< class T1, class T2 > std::pair<T1,T2> make_pair(const T1& t, const T2& u );
 }
 
 // --- map ---

cpp/ql/test/library-tests/dataflow/taint-tests/test_diff.expected

@@ -28,9 +28,7 @@
 | map.cpp:76:9:76:13 | map.cpp:63:37:63:42 | IR only |
 | map.cpp:77:9:77:14 | map.cpp:63:37:63:42 | IR only |
 | map.cpp:84:34:84:38 | map.cpp:84:17:84:22 | IR only |
-| map.cpp:85:7:85:39 | map.cpp:85:17:85:22 | IR only |
 | map.cpp:85:34:85:39 | map.cpp:85:17:85:22 | IR only |
-| map.cpp:87:7:87:38 | map.cpp:87:24:87:29 | IR only |
 | map.cpp:87:34:87:38 | map.cpp:87:24:87:29 | IR only |
 | map.cpp:88:34:88:39 | map.cpp:88:24:88:29 | IR only |
 | map.cpp:92:7:92:7 | map.cpp:91:33:91:38 | AST only |

cpp/ql/test/library-tests/dataflow/taint-tests/test_ir.expected

@@ -70,10 +70,8 @@
 | map.cpp:78:7:78:7 | l | map.cpp:63:37:63:42 | call to source |
 | map.cpp:83:7:83:32 | call to pair | map.cpp:83:17:83:22 | call to source |
 | map.cpp:84:34:84:38 | first | map.cpp:84:17:84:22 | call to source |
-| map.cpp:85:7:85:39 | (reference dereference) | map.cpp:85:17:85:22 | call to source |
 | map.cpp:85:34:85:39 | second | map.cpp:85:17:85:22 | call to source |
 | map.cpp:86:7:86:32 | call to pair | map.cpp:86:24:86:29 | call to source |
-| map.cpp:87:7:87:38 | (reference dereference) | map.cpp:87:24:87:29 | call to source |
 | map.cpp:87:34:87:38 | first | map.cpp:87:24:87:29 | call to source |
 | map.cpp:88:34:88:39 | second | map.cpp:88:24:88:29 | call to source |
 | map.cpp:93:9:93:13 | first | map.cpp:91:33:91:38 | call to source |