Skip to content

Commit 80cb8be

Browse files
authored
Merge pull request #4155 from asger-semmle/js/lower-duplicate-element-id-precision
Approved by esbena
2 parents ac94869 + e7a0bc6 commit 80cb8be

File tree

3 files changed

+2
-2
lines changed

3 files changed

+2
-2
lines changed

change-notes/1.26/analysis-javascript.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@
2727
| **Query** | **Expected impact** | **Change** |
2828
|--------------------------------|------------------------------|---------------------------------------------------------------------------|
2929
| Incomplete URL substring sanitization (`js/incomplete-url-substring-sanitization`) | More results | This query now recognizes additional URLs when the substring check is an inclusion check. |
30+
| Ambiguous HTML id attribute (`js/duplicate-html-id`) | Results no longer shown | Precision tag reduced to "low". The query is no longer run by default. |
3031

3132

3233
## Changes to libraries

javascript/config/suites/javascript/correctness-core

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77
+ semmlecode-javascript-queries/Declarations/UniqueParameterNames.ql: /Correctness/Declarations
88
+ semmlecode-javascript-queries/Declarations/UniquePropertyNames.ql: /Correctness/Declarations
99
+ semmlecode-javascript-queries/Declarations/IneffectiveParameterType.ql: /Correctness/Declarations
10-
+ semmlecode-javascript-queries/DOM/AmbiguousIdAttribute.ql: /Correctness/DOM
1110
+ semmlecode-javascript-queries/DOM/ConflictingAttributes.ql: /Correctness/DOM
1211
+ semmlecode-javascript-queries/DOM/MalformedIdAttribute.ql: /Correctness/DOM
1312
+ semmlecode-javascript-queries/Expressions/ComparisonWithNaN.ql: /Correctness/Expressions

javascript/ql/src/DOM/AmbiguousIdAttribute.ql

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
* @id js/duplicate-html-id
99
* @tags maintainability
1010
* correctness
11-
* @precision high
11+
* @precision low
1212
*/
1313

1414
import javascript

0 commit comments

Comments
 (0)