Skip to content

Commit 8124980

Browse files
committed
JavaScript: Add change note and comment.
1 parent a674dbb commit 8124980

File tree

2 files changed

+6
-1
lines changed

2 files changed

+6
-1
lines changed

change-notes/1.21/analysis-javascript.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,5 +19,6 @@
1919
|--------------------------------|------------------------------|---------------------------------------------------------------------------|
2020
| Expression has no effect | Fewer false-positive results | This rule now treats uses of `Object.defineProperty` more conservatively. |
2121
| Useless assignment to property | Fewer false-positive results | This rule now ignore reads of additional getters. |
22+
| ZipSlip | More results | This rule now considers more libraries, including tar as well as zip. |
2223

2324
## Changes to QL libraries

javascript/ql/src/semmle/javascript/security/dataflow/ZipSlip.qll

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,11 @@ module ZipSlip {
6060
}
6161

6262
/** Gets a property that is used to get the filename part of an archive entry. */
63-
private string getAFilenameProperty() { result = "path" or result = "name" }
63+
private string getAFilenameProperty() {
64+
result = "path" // Used by library 'unzip'.
65+
or
66+
result = "name" // Used by library 'tar-stream'.
67+
}
6468

6569
/** An archive entry path access, as a source for unsafe archive extraction. */
6670
class UnzipEntrySource extends Source {

0 commit comments

Comments
 (0)