Fixup of implementation to propagate call completion.

michaelnebel · michaelnebel · commit 82f0404d49bd · 2026-01-16T10:12:32.000+01:00
diff --git a/csharp/ql/lib/semmle/code/csharp/controlflow/internal/ControlFlowGraphImpl.qll b/csharp/ql/lib/semmle/code/csharp/controlflow/internal/ControlFlowGraphImpl.qll
@@ -542,8 +542,10 @@ module Expressions {
     }
 
     final override predicate last(AstNode last, Completion c) {
+      // The last ast node is the last out writeaccess.
+      // Completion from the call itself is propagated (required for eg. conditions).
       last = this.getLastOutAccess() and
-      c.isValidFor(last)
+      c.isValidFor(this)
     }
 
     final override predicate succ(AstNode pred, AstNode succ, Completion c) {

Original file line number	Diff line number	Diff line change
`@@ -542,8 +542,10 @@ module Expressions {`
`542`	`542`	`}`
`543`	`543`
`544`	`544`	`final override predicate last(AstNode last, Completion c) {`
	`545`	`+ // The last ast node is the last out writeaccess.`
	`546`	`+ // Completion from the call itself is propagated (required for eg. conditions).`
`545`	`547`	`last = this.getLastOutAccess() and`
`546`		`- c.isValidFor(last)`
	`548`	`+ c.isValidFor(this)`
`547`	`549`	`}`
`548`	`550`
`549`	`551`	`final override predicate succ(AstNode pred, AstNode succ, Completion c) {`