Merge pull request #856 from jbj/ir-getInstructionOperandDefinition

C++: Speed up `getInstructionOperandDefinition`

Author: dave-bartolomeo

cpp/ql/src/semmle/code/cpp/ir/implementation/aliased_ssa/FunctionIR.qll

@@ -56,6 +56,11 @@ class FunctionIR extends TFunctionIR {
     result.getFunctionIR() = this
   }
 
+  pragma[noinline]
+  final UnmodeledUseInstruction getUnmodeledUseInstruction() {
+    result.getFunctionIR() = this
+  }
+
   /**
    * Gets the single return instruction for this function.
    */

cpp/ql/src/semmle/code/cpp/ir/implementation/aliased_ssa/internal/SSAConstruction.qll

@@ -192,10 +192,11 @@ cached private module Cached {
     instruction.getTag() = ChiTag(getOldInstruction(result)) and
     tag instanceof ChiPartialOperandTag
     or
-    instruction instanceof UnmodeledUseInstruction and
-    tag instanceof UnmodeledUseOperandTag and
-    result  instanceof UnmodeledDefinitionInstruction and
-    instruction.getFunction() = result.getFunction()
+    exists(FunctionIR f |
+      tag instanceof UnmodeledUseOperandTag and
+      result = f.getUnmodeledDefinitionInstruction() and
+      instruction = f.getUnmodeledUseInstruction()
+    )
     or
     tag instanceof ChiTotalOperandTag and
     result = getChiInstructionTotalOperand(instruction)

cpp/ql/src/semmle/code/cpp/ir/implementation/raw/FunctionIR.qll

@@ -56,6 +56,11 @@ class FunctionIR extends TFunctionIR {
     result.getFunctionIR() = this
   }
 
+  pragma[noinline]
+  final UnmodeledUseInstruction getUnmodeledUseInstruction() {
+    result.getFunctionIR() = this
+  }
+
   /**
    * Gets the single return instruction for this function.
    */

cpp/ql/src/semmle/code/cpp/ir/implementation/unaliased_ssa/FunctionIR.qll

@@ -56,6 +56,11 @@ class FunctionIR extends TFunctionIR {
     result.getFunctionIR() = this
   }
 
+  pragma[noinline]
+  final UnmodeledUseInstruction getUnmodeledUseInstruction() {
+    result.getFunctionIR() = this
+  }
+
   /**
    * Gets the single return instruction for this function.
    */

cpp/ql/src/semmle/code/cpp/ir/implementation/unaliased_ssa/internal/SSAConstruction.qll

@@ -192,10 +192,11 @@ cached private module Cached {
     instruction.getTag() = ChiTag(getOldInstruction(result)) and
     tag instanceof ChiPartialOperandTag
     or
-    instruction instanceof UnmodeledUseInstruction and
-    tag instanceof UnmodeledUseOperandTag and
-    result  instanceof UnmodeledDefinitionInstruction and
-    instruction.getFunction() = result.getFunction()
+    exists(FunctionIR f |
+      tag instanceof UnmodeledUseOperandTag and
+      result = f.getUnmodeledDefinitionInstruction() and
+      instruction = f.getUnmodeledUseInstruction()
+    )
     or
     tag instanceof ChiTotalOperandTag and
     result = getChiInstructionTotalOperand(instruction)