Skip to content

Commit 8909c3d

Browse files
committed
Python: Fix tags and message for CWE-312 queries.
1 parent 4759044 commit 8909c3d

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

python/ql/src/Security/CWE-312/CleartextLogging.ql

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
* @kind path-problem
66
* @problem.severity error
77
* @precision high
8-
* @id py/clear-text-storage-of-sensitive-data
8+
* @id py/clear-text-logging-sensitive-data
99
* @tags security
1010
* external/cwe/cwe-312
1111
* external/cwe/cwe-315
@@ -37,5 +37,5 @@ class CleartextLoggingConfiguration extends TaintTracking::Configuration {
3737

3838
from CleartextLoggingConfiguration config, TaintedPathSource source, TaintedPathSink sink
3939
where config.hasFlowPath(source, sink)
40-
select sink.getSink(), source, sink, "Sensitive data returned by $@ is stored here.",
40+
select sink.getSink(), source, sink, "Sensitive data returned by $@ is logged here.",
4141
source.getSource(), source.getNode().(SensitiveData::Source).repr()

python/ql/src/Security/CWE-312/CleartextStorage.ql

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
* @kind path-problem
66
* @problem.severity error
77
* @precision high
8-
* @id py/clear-text-logging
8+
* @id py/clear-text-storage-sensitive-data
99
* @tags security
1010
* external/cwe/cwe-312
1111
* external/cwe/cwe-315

python/ql/test/query-tests/Security/CWE-312/CleartextLogging.expected

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,5 +4,5 @@ edges
44
| password_in_cookie.py:7:16:7:43 | externally controlled string | password_in_cookie.py:9:33:9:40 | externally controlled string |
55
| test.py:7:16:7:29 | a password | test.py:8:35:8:42 | a password |
66
#select
7-
| test.py:8:35:8:42 | Taint sink | test.py:7:16:7:29 | a password | test.py:8:35:8:42 | a password | Sensitive data returned by $@ is stored here. | test.py:7:16:7:29 | Taint source | a call returning a password |
8-
| test.py:14:30:14:39 | Taint sink | test.py:14:30:14:39 | a certificate or key | test.py:14:30:14:39 | a certificate or key | Sensitive data returned by $@ is stored here. | test.py:14:30:14:39 | Taint source | a call returning a certificate or key |
7+
| test.py:8:35:8:42 | Taint sink | test.py:7:16:7:29 | a password | test.py:8:35:8:42 | a password | Sensitive data returned by $@ is logged here. | test.py:7:16:7:29 | Taint source | a call returning a password |
8+
| test.py:14:30:14:39 | Taint sink | test.py:14:30:14:39 | a certificate or key | test.py:14:30:14:39 | a certificate or key | Sensitive data returned by $@ is logged here. | test.py:14:30:14:39 | Taint source | a call returning a certificate or key |

0 commit comments

Comments
 (0)