Skip to content

Commit 895055f

Browse files
author
Max Schaefer
committed
JavaScript: Avoid unhelpful magic.
The constraint `exists(callback.getParameter(i))` was getting pushed into `higherOrderCall`, which isn't a bad thing to do. However, this then led to a join on `i`, which is a very bad thing to do.
1 parent b5b89c0 commit 895055f

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

javascript/ql/src/semmle/javascript/dataflow/Configuration.qll

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -838,6 +838,7 @@ private predicate summarizedHigherOrderCall(
838838
* - The flow label mapping of the summary corresponds to the transformation from `arg` to the
839839
* invocation of the callback.
840840
*/
841+
pragma[nomagic]
841842
private predicate higherOrderCall(
842843
DataFlow::Node arg, DataFlow::SourceNode callback, int i, DataFlow::Configuration cfg,
843844
PathSummary summary

0 commit comments

Comments
 (0)