Skip to content

Commit 8af8c6d

Browse files
committed
Rust: Move upgrade script to the very end, add a few details.
1 parent 9a96372 commit 8af8c6d

File tree

1 file changed

+6
-4
lines changed

1 file changed

+6
-4
lines changed

rust/README.md

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ installing [`cargo-edit`](https://crates.io/crates/cargo-edit) with `cargo insta
8888
```
8989
bazel run //rust/codegen
9090
```
91-
Take note whether `rust/schema/ast.py` was changed. That might need tweaks, new tests and/or downgrade/upgrade scripts down the line
91+
Take note whether `rust/schema/ast.py` was changed. That might need tweaks, new tests and/or downgrade/upgrade scripts down the line.
9292
6. Try compiling
9393
```
9494
bazel run //rust:install
@@ -105,6 +105,8 @@ installing [`cargo-edit`](https://crates.io/crates/cargo-edit) with `cargo insta
105105

106106
If you had to do any changes, commit them. If you updated the rust toolchain, running `rust/lint.py` might reformat or apply new
107107
lints to the code.
108-
7. If in step 5 the schema was updated, add upgrade/downgrade scripts and a change note
109-
8. Check with CI if everything is in order.
110-
9. Run DCA. Iterate on the code if needed.
108+
7. Check with CI if everything is in order.
109+
8. Run DCA. Iterate on the code if needed.
110+
9. If in step 5 the schema was updated, add upgrade/downgrade scripts and a change note. This is best done last to reduce the chance of
111+
merge conflicts (none of the other testing depends on having upgrade and downgrade scripts in place). See
112+
[Upgrading a language database schema](docs/prepare-db-upgrade.md).

0 commit comments

Comments
 (0)