Merge pull request #1537 from geoffw0/add-tests

CPP: Add some tests

Author: jbj

cpp/ql/src/Likely Bugs/Memory Management/Padding/NonPortablePrintf.ql

@@ -84,5 +84,5 @@ where (
       and not arg.isAffectedByMacro()
       and size32 = ilp32.paddedSize(actual) and size64 = lp64.paddedSize(actual)
       and size64 != size32
-select arg, "This argument should be of type "+expected.getName()+" but is of type "+actual.getName() +
-  " (which changes size from " + size32 + " to " + size64 + " on 64-bit systems)."
+select arg, "This argument should be of type '" + expected.getName() + "' but is of type '" + actual.getName() +
+  "' (which changes size from " + size32 + " to " + size64 + " on 64-bit systems)."

cpp/ql/test/library-tests/functions/getathrowntype/getAThrownType.expected

@@ -0,0 +1,11 @@
+| test.cpp:2:6:2:10 | func1 |  | isNoExcept |
+| test.cpp:3:6:3:10 | func2 |  |  |
+| test.cpp:4:6:4:10 | func3 |  |  |
+| test.cpp:5:6:5:10 | func4 |  |  |
+| test.cpp:6:6:6:10 | func5 |  |  |
+| test.cpp:8:6:8:10 | func6 |  | isNoThrow |
+| test.cpp:9:6:9:10 | func7 | int |  |
+| test.cpp:11:6:11:10 | func8 | char, int |  |
+| test.cpp:15:7:15:7 | operator= |  | isNoThrow |
+| test.cpp:15:7:15:7 | operator= |  | isNoThrow |
+| test.cpp:17:7:17:11 | func9 |  | isNoThrow |

cpp/ql/test/library-tests/functions/getathrowntype/getAThrownType.ql

@@ -0,0 +1,15 @@
+import cpp
+
+string describe(Function f) {
+	(
+		f.isNoThrow() and
+		result = "isNoThrow"
+	) or (
+		f.isNoExcept() and
+		result = "isNoExcept"
+	)
+}
+
+from Function f
+where exists(f.getFile())
+select f, concat(f.getAThrownType().toString(), ", "), concat(describe(f), ", ")

cpp/ql/test/library-tests/functions/getathrowntype/test.cpp

@@ -0,0 +1,18 @@
+
+void func1() noexcept;
+void func2() noexcept(true);
+void func3() noexcept(false);
+void func4() noexcept(func1);
+void func5(void param() noexcept);
+
+void func6() throw();
+void func7() throw(int);
+void func8() throw(char, int);
+void func8() throw(char, int)
+{
+}
+
+class c
+{
+	void func9() throw();
+};

cpp/ql/test/query-tests/Likely Bugs/Memory Management/Padding/More64BitWaste/More64BitWaste.expected

@@ -0,0 +1,2 @@
+| test.cpp:17:8:17:12 | test4 | test4 includes 0 bits of padding on ILP32, but 32 bits on LP64. |
+| test.cpp:29:8:29:12 | test6 | test6 includes 0 bits of padding on ILP32, but 32 bits on LP64. |

cpp/ql/test/query-tests/Likely Bugs/Memory Management/Padding/More64BitWaste/More64BitWaste.qlref

@@ -0,0 +1 @@
+Likely Bugs/Memory Management/Padding/More64BitWaste.ql

cpp/ql/test/query-tests/Likely Bugs/Memory Management/Padding/More64BitWaste/test.cpp

@@ -0,0 +1,39 @@
+
+struct test1
+{
+	int x;
+};
+
+struct test2
+{
+	int x, y;
+};
+
+struct test3
+{
+	int x, y, z;
+};
+
+struct test4 // BAD
+{
+	int a;
+	long long b;
+};
+
+struct test5
+{
+	long long a;
+	int b;
+};
+
+struct test6 // BAD
+{
+	char as[4];
+	long long b;
+};
+
+struct test7
+{
+	char as[8];
+	long long b;
+};

cpp/ql/test/query-tests/Likely Bugs/Memory Management/Padding/NonPortablePrintf/NonPortablePrintf.expected

@@ -0,0 +1,4 @@
+| test.cpp:10:17:10:17 | l | This argument should be of type 'int' but is of type 'long' (which changes size from 32 to 64 on 64-bit systems). |
+| test.cpp:13:17:13:19 | ptr | This argument should be of type 'int' but is of type 'void *' (which changes size from 32 to 64 on 64-bit systems). |
+| test.cpp:14:17:14:19 | ptr | This argument should be of type 'unsigned int' but is of type 'void *' (which changes size from 32 to 64 on 64-bit systems). |
+| test.cpp:15:17:15:19 | ptr | This argument should be of type 'unsigned int' but is of type 'void *' (which changes size from 32 to 64 on 64-bit systems). |

cpp/ql/test/query-tests/Likely Bugs/Memory Management/Padding/NonPortablePrintf/NonPortablePrintf.qlref

@@ -0,0 +1 @@
+Likely Bugs/Memory Management/Padding/NonPortablePrintf.ql

cpp/ql/test/query-tests/Likely Bugs/Memory Management/Padding/NonPortablePrintf/test.cpp

@@ -0,0 +1,16 @@
+
+int printf(const char *format, ...);
+
+void test1()
+{
+	long l;
+	void *ptr;
+
+	printf("%ld\n", l); // GOOD
+	printf("%d\n", l); // BAD
+
+	printf("%p\n", ptr); // GOOD
+	printf("%d\n", ptr); // BAD
+	printf("%u\n", ptr); // BAD
+	printf("%x\n", ptr); // BAD
+}