Skip to content

Commit 8d59df2

Browse files
committed
JS: Allow calls to externs
1 parent cfa2ec1 commit 8d59df2

File tree

1 file changed

+0
-2
lines changed
  • javascript/ql/src/semmle/javascript/dataflow/internal

1 file changed

+0
-2
lines changed

javascript/ql/src/semmle/javascript/dataflow/internal/FlowSteps.qll

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,6 @@ private module CachedSteps {
119119
predicate calls(DataFlow::InvokeNode invk, Function f) {
120120
f = invk.getACallee(0)
121121
or
122-
not f.getTopLevel().isExterns() and
123122
exists(DataFlow::ClassNode cls, string name |
124123
callResolvesToMember(invk, cls, name) and
125124
f = cls.getInstanceMethod(name).getFunction()
@@ -129,7 +128,6 @@ private module CachedSteps {
129128
)
130129
or
131130
// Call from `foo.bar.baz()` to `foo.bar.baz = function()`
132-
not f.getTopLevel().isExterns() and
133131
exists(string name |
134132
GlobalAccessPath::isAssignedInUniqueFile(name) and
135133
GlobalAccessPath::fromRhs(f.flow()) = name and

0 commit comments

Comments
 (0)