JS: add support for fs-extra in NodeJSFileSystemAccess

Esben Sparre Andreasen · Esben Sparre Andreasen · commit 8de269e1fb9a · 2018-09-14T11:09:29.000+02:00
diff --git a/javascript/ql/src/semmle/javascript/frameworks/NodeJSLib.qll b/javascript/ql/src/semmle/javascript/frameworks/NodeJSLib.qll
@@ -338,14 +338,14 @@ module NodeJSLib {
 
 
   /**
-   * A call to a method from module `fs` or `graceful-fs`.
+   * A call to a method from module `fs`, `graceful-fs` or `fs-extra`.
    */
   private class NodeJSFileSystemAccess extends FileSystemAccess, DataFlow::CallNode {
     string methodName;
 
     NodeJSFileSystemAccess() {
       exists (string moduleName | this = DataFlow::moduleMember(moduleName, methodName).getACall() |
-        moduleName = "fs" or moduleName = "graceful-fs"
+        moduleName = "fs" or moduleName = "graceful-fs" or moduleName = "fs-extra"
       )
     }
 

Original file line number	Diff line number	Diff line change
`@@ -338,14 +338,14 @@ module NodeJSLib {`
`338`	`338`
`339`	`339`
`340`	`340`	`/**`
`341`		- * A call to a method from module `fs` or `graceful-fs`.
	`341`	+ * A call to a method from module `fs`, `graceful-fs` or `fs-extra`.
`342`	`342`	`*/`
`343`	`343`	`private class NodeJSFileSystemAccess extends FileSystemAccess, DataFlow::CallNode {`
`344`	`344`	`string methodName;`
`345`	`345`
`346`	`346`	`NodeJSFileSystemAccess() {`
`347`	`347`	`exists (string moduleName \| this = DataFlow::moduleMember(moduleName, methodName).getACall() \|`
`348`		`- moduleName = "fs" or moduleName = "graceful-fs"`
	`348`	`+ moduleName = "fs" or moduleName = "graceful-fs" or moduleName = "fs-extra"`
`349`	`349`	`)`
`350`	`350`	`}`
`351`	`351`