Skip to content

Commit 8e1f99a

Browse files
tausbnRasmusWL
andauthored
Python: Apply suggestions from code review
Co-authored-by: Rasmus Wriedt Larsen <rasmuswriedtlarsen@gmail.com>
1 parent 7108d28 commit 8e1f99a

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

python/ql/src/experimental/dataflow/TypeTracker.qll

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ class OptionalAttributeName extends string {
1717
/**
1818
* A description of a step on an inter-procedural data flow path.
1919
*/
20-
newtype TStepSummary =
20+
private newtype TStepSummary =
2121
LevelStep() or
2222
CallStep() or
2323
ReturnStep() or
@@ -80,7 +80,7 @@ predicate callStep(ArgumentNode pred, ParameterNode succ) {
8080
/** Holds if `pred` steps to `succ` by being returned from a call. */
8181
predicate returnStep(ReturnNode pred, Node succ) {
8282
exists(DataFlowCall call |
83-
pred.getEnclosingCallable() = call.getCallable() and succ = TCfgNode(call.getNode())
83+
pred.getEnclosingCallable() = call.getCallable() and succ.asCfgNode() = call
8484
)
8585
}
8686

@@ -128,7 +128,7 @@ predicate basicLoadStep(Node pred, Node succ, string attr) {
128128
/**
129129
* A utility class that is equivalent to `boolean` but does not require type joining.
130130
*/
131-
class Boolean extends boolean {
131+
private class Boolean extends boolean {
132132
Boolean() { this = true or this = false }
133133
}
134134

0 commit comments

Comments
 (0)