Merge pull request #58 from xiemaisi/js/demote-heterogeneous-comparison

Approved by asger-semmle

Author: semmle-qlci

change-notes/1.18/analysis-javascript.md

@@ -81,6 +81,7 @@
 | **Query**                  | **Expected impact**    | **Change**                                                       |
 |----------------------------|------------------------|------------------------------------------------------------------|
 | Arguments redefined | Fewer results | This rule previously also flagged redefinitions of `eval`. This was an oversight that is now fixed. |
+| Comparison between inconvertible types | Lower severity | The severity of this rule has been revised to "warning". |
 | CORS misconfiguration for credentials transfer | More true-positive results | This rule now treats header names case-insensitively. |
 | Hard-coded credentials | More true-positive results | This rule now recognizes secret cryptographic keys. |
 | Incomplete sanitization | More true-positive results | This rule now recognizes incomplete URL encoding and decoding. |

javascript/ql/src/Expressions/HeterogeneousComparison.ql

@@ -4,7 +4,7 @@
  *              the same type will always yield 'false', and an inequality comparison will always
  *              yield 'true'.
  * @kind problem
- * @problem.severity error
+ * @problem.severity warning
  * @id js/comparison-between-incompatible-types
  * @tags reliability
  *       correctness