Add logging to attribute decoding failures

tamasvajk · tamasvajk · commit 8e6e4189b38e · 2020-12-09T21:04:12.000+01:00
diff --git a/csharp/extractor/Semmle.Extraction.CIL/Entities/Attribute.cs b/csharp/extractor/Semmle.Extraction.CIL/Entities/Attribute.cs
@@ -45,7 +45,8 @@ public override IEnumerable<IExtractionProduct> Contents
                 }
                 catch (Exception exc)
                 {
-                    // Attribute decoding is only partial at this stage.
+                    Cx.Cx.Extractor.Logger.Log(Util.Logging.Severity.Info,
+                        $"Attribute decoding is partial. Decoding attribute {constructor.DeclaringType.GetQualifiedName()} failed on {@object}.");
                     yield break;
                 }
 

Original file line number	Diff line number	Diff line change
`@@ -45,7 +45,8 @@ public override IEnumerable<IExtractionProduct> Contents`
`45`	`45`	`}`
`46`	`46`	`catch (Exception exc)`
`47`	`47`	`{`
`48`		`- // Attribute decoding is only partial at this stage.`
	`48`	`+ Cx.Cx.Extractor.Logger.Log(Util.Logging.Severity.Info,`
	`49`	`+ $"Attribute decoding is partial. Decoding attribute {constructor.DeclaringType.GetQualifiedName()} failed on {@object}.");`
`49`	`50`	`yield break;`
`50`	`51`	`}`
`51`	`52`