Skip to content

Commit 940254d

Browse files
authored
update framework tests
1 parent b486915 commit 940254d

File tree

2 files changed

+14
-0
lines changed

2 files changed

+14
-0
lines changed

ruby/ql/test/library-tests/frameworks/ActiveRecord.expected

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@ activeRecordSqlExecutionRanges
2222
| ActiveRecord.rb:46:20:46:32 | ... + ... |
2323
| ActiveRecord.rb:52:16:52:28 | "name #{...}" |
2424
| ActiveRecord.rb:56:20:56:39 | "username = #{...}" |
25+
| ActiveRecord.rb:78:27:78:76 | "this is an unsafe annotation:..." |
2526
activeRecordModelClassMethodCalls
2627
| ActiveRecord.rb:2:3:2:17 | call to has_many |
2728
| ActiveRecord.rb:6:3:6:24 | call to belongs_to |
@@ -44,6 +45,8 @@ activeRecordModelClassMethodCalls
4445
| ActiveRecord.rb:60:5:60:33 | call to find_by |
4546
| ActiveRecord.rb:62:5:62:34 | call to find |
4647
| ActiveRecord.rb:68:5:68:45 | call to delete_by |
48+
| ActiveRecord.rb:74:13:74:54 | call to annotate |
49+
| ActiveRecord.rb:78:13:78:77 | call to annotate |
4750
potentiallyUnsafeSqlExecutingMethodCall
4851
| ActiveRecord.rb:9:5:9:68 | call to find |
4952
| ActiveRecord.rb:19:5:19:25 | call to destroy_by |
@@ -55,6 +58,7 @@ potentiallyUnsafeSqlExecutingMethodCall
5558
| ActiveRecord.rb:46:5:46:33 | call to delete_by |
5659
| ActiveRecord.rb:52:5:52:29 | call to order |
5760
| ActiveRecord.rb:56:7:56:40 | call to find_by |
61+
| ActiveRecord.rb:78:13:78:77 | call to annotate |
5862
activeRecordModelInstantiations
5963
| ActiveRecord.rb:9:5:9:68 | call to find | ActiveRecord.rb:5:1:15:3 | User |
6064
| ActiveRecord.rb:13:5:13:40 | call to find_by | ActiveRecord.rb:1:1:3:3 | UserGroup |

ruby/ql/test/library-tests/frameworks/ActiveRecord.rb

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -68,3 +68,13 @@ def yet_another_handler
6868
Admin.delete_by(params[:admin_condition])
6969
end
7070
end
71+
72+
class AnnotatedController < ActionController::Base
73+
def index
74+
users = User.annotate("this is a safe annotation")
75+
end
76+
77+
def unsafe_action
78+
users = User.annotate("this is an unsafe annotation:#{params[:comment]}")
79+
end
80+
end

0 commit comments

Comments
 (0)