Skip to content

Commit 95743d7

Browse files
committed
Added inline test expectations for cors permissive config
1 parent 92daa7d commit 95743d7

File tree

3 files changed

+9
-8
lines changed

3 files changed

+9
-8
lines changed
Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1,2 @@
1-
Security/CWE-942/CorsPermissiveConfiguration.ql
1+
query: Security/CWE-942/CorsPermissiveConfiguration.ql
2+
postprocess: utils/test/InlineExpectationsTestQuery.ql

javascript/ql/test/query-tests/Security/CWE-942/apollo-test.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,10 +5,10 @@ var https = require('https'),
55
var server = https.createServer(function () { });
66

77
server.on('request', function (req, res) {
8-
let user_origin = url.parse(req.url, true).query.origin;
8+
let user_origin = url.parse(req.url, true).query.origin; // $ Source
99
// BAD: CORS too permissive
1010
const server_1 = new ApolloServer({
11-
cors: { origin: true }
11+
cors: { origin: true } // $ Alert
1212
});
1313

1414
// GOOD: restrictive CORS
@@ -18,11 +18,11 @@ server.on('request', function (req, res) {
1818

1919
// BAD: CORS too permissive
2020
const server_3 = new ApolloServer({
21-
cors: { origin: null }
21+
cors: { origin: null } // $ Alert
2222
});
2323

2424
// BAD: CORS is controlled by user
2525
const server_4 = new ApolloServer({
26-
cors: { origin: user_origin }
26+
cors: { origin: user_origin } // $ Alert
2727
});
2828
});

javascript/ql/test/query-tests/Security/CWE-942/express-test.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ var https = require('https'),
77
var server = https.createServer(function () { });
88

99
server.on('request', function (req, res) {
10-
let user_origin = url.parse(req.url, true).query.origin;
10+
let user_origin = url.parse(req.url, true).query.origin; // $ Source
1111

1212
// BAD: CORS too permissive, default value is *
1313
var app1 = express();
@@ -23,14 +23,14 @@ server.on('request', function (req, res) {
2323
// BAD: CORS too permissive
2424
var app3 = express();
2525
var corsOption3 = {
26-
origin: '*'
26+
origin: '*' // $ Alert
2727
};
2828
app3.use(cors(corsOption3));
2929

3030
// BAD: CORS is controlled by user
3131
var app4 = express();
3232
var corsOption4 = {
33-
origin: user_origin
33+
origin: user_origin // $ Alert
3434
};
3535
app4.use(cors(corsOption4));
3636
});

0 commit comments

Comments
 (0)