Crypto: Update JCA 'wihHmac" raw name to be the entire raw string, not just "Hmac"

bdrodes · bdrodes · commit 9673b816778d · 2025-10-02T11:49:23.000-04:00
diff --git a/java/ql/lib/experimental/quantum/JCA.qll b/java/ql/lib/experimental/quantum/JCA.qll
@@ -1244,10 +1244,7 @@ module JCAModel {
 
     override Crypto::PaddingAlgorithmInstance getPaddingAlgorithm() { none() }
 
-    override string getRawAlgorithmName() {
-      // Note: hardcoding "hmac" since that should be the only option
-      result = "Hmac"
-    }
+    override string getRawAlgorithmName() { result = this.(StringLiteral).getValue() }
   }
 
   class Pbkdf2WithHmac_HashAlgorithmStringLiteral extends Crypto::HashAlgorithmInstance instanceof Pbkdf2WithHmac_KeyOperationAlgorithmStringLiteral

Original file line number	Diff line number	Diff line change
`@@ -1244,10 +1244,7 @@ module JCAModel {`
`1244`	`1244`
`1245`	`1245`	`override Crypto::PaddingAlgorithmInstance getPaddingAlgorithm() { none() }`
`1246`	`1246`
`1247`		`- override string getRawAlgorithmName() {`
`1248`		`- // Note: hardcoding "hmac" since that should be the only option`
`1249`		`- result = "Hmac"`
`1250`		`- }`
	`1247`	`+ override string getRawAlgorithmName() { result = this.(StringLiteral).getValue() }`
`1251`	`1248`	`}`
`1252`	`1249`
`1253`	`1250`	`class Pbkdf2WithHmac_HashAlgorithmStringLiteral extends Crypto::HashAlgorithmInstance instanceof Pbkdf2WithHmac_KeyOperationAlgorithmStringLiteral`