Merge pull request #51 from calumgrant/cs/lgtm-query-suites-submodule

C#: Move query suite files into submodule

Author: hvitved

csharp/config/suites/lgtm/csharp-alerts-lgtm

@@ -0,0 +1,310 @@
+# Auto-generated by:
+# ./build target/general/lgtm-query-suites/output/csharp-alerts-lgtm
++ semmlecode-csharp-queries/API Abuse/CallToGCCollect.ql
+  @_namespace com.lgtm/csharp-queries
++ semmlecode-csharp-queries/API Abuse/CallToObsoleteMethod.ql
+  @_namespace com.lgtm/csharp-queries
++ semmlecode-csharp-queries/API Abuse/ClassDoesNotImplementEquals.ql
+  @_namespace com.lgtm/csharp-queries
++ semmlecode-csharp-queries/API Abuse/ClassImplementsICloneable.ql
+  @_namespace com.lgtm/csharp-queries
++ semmlecode-csharp-queries/API Abuse/DisposeNotCalledOnException.ql
+  @_namespace com.lgtm/csharp-queries
++ semmlecode-csharp-queries/API Abuse/FormatInvalid.ql
+  @_namespace com.lgtm/csharp-queries
++ semmlecode-csharp-queries/API Abuse/FormatMissingArgument.ql
+  @_namespace com.lgtm/csharp-queries
++ semmlecode-csharp-queries/API Abuse/FormatUnusedArgument.ql
+  @_namespace com.lgtm/csharp-queries
++ semmlecode-csharp-queries/API Abuse/InconsistentEqualsGetHashCode.ql
+  @_namespace com.lgtm/csharp-queries
++ semmlecode-csharp-queries/API Abuse/IncorrectCompareToSignature.ql
+  @_namespace com.lgtm/csharp-queries
++ semmlecode-csharp-queries/API Abuse/IncorrectEqualsSignature.ql
+  @_namespace com.lgtm/csharp-queries
++ semmlecode-csharp-queries/API Abuse/NoDisposeCallOnLocalIDisposable.ql
+  @_namespace com.lgtm/csharp-queries
++ semmlecode-csharp-queries/API Abuse/NullArgumentToEquals.ql
+  @_namespace com.lgtm/csharp-queries
++ semmlecode-csharp-queries/ASP/BlockCodeResponseWrite.ql
+  @_namespace com.lgtm/csharp-queries
++ semmlecode-csharp-queries/Architecture/Refactoring Opportunities/InappropriateIntimacy.ql
+  @_namespace com.lgtm/csharp-queries
++ semmlecode-csharp-queries/Bad Practices/CallsUnmanagedCode.ql
+  @_namespace com.lgtm/csharp-queries
++ semmlecode-csharp-queries/Bad Practices/CatchOfNullReferenceException.ql
+  @_namespace com.lgtm/csharp-queries
++ semmlecode-csharp-queries/Bad Practices/Control-Flow/ConstantCondition.ql
+  @_namespace com.lgtm/csharp-queries
++ semmlecode-csharp-queries/Bad Practices/Declarations/LocalScopeVariableShadowsMember.ql
+  @_namespace com.lgtm/csharp-queries
++ semmlecode-csharp-queries/Bad Practices/Declarations/TooManyRefParameters.ql
+  @_namespace com.lgtm/csharp-queries
++ semmlecode-csharp-queries/Bad Practices/EmptyCatchBlock.ql
+  @_namespace com.lgtm/csharp-queries
++ semmlecode-csharp-queries/Bad Practices/ErroneousClassCompare.ql
+  @_namespace com.lgtm/csharp-queries
++ semmlecode-csharp-queries/Bad Practices/Implementation Hiding/AbstractToConcreteCollection.ql
+  @_namespace com.lgtm/csharp-queries
++ semmlecode-csharp-queries/Bad Practices/Implementation Hiding/ExposeRepresentation.ql
+  @_namespace com.lgtm/csharp-queries
++ semmlecode-csharp-queries/Bad Practices/Naming Conventions/FieldMasksSuperField.ql
+  @_namespace com.lgtm/csharp-queries
++ semmlecode-csharp-queries/Bad Practices/Naming Conventions/SameNameAsSuper.ql
+  @_namespace com.lgtm/csharp-queries
++ semmlecode-csharp-queries/Bad Practices/UnmanagedCodeCheck.ql
+  @_namespace com.lgtm/csharp-queries
++ semmlecode-csharp-queries/Bad Practices/VirtualCallInConstructorOrDestructor.ql
+  @_namespace com.lgtm/csharp-queries
++ semmlecode-csharp-queries/CSI/CompareIdenticalValues.ql
+  @_namespace com.lgtm/csharp-queries
++ semmlecode-csharp-queries/CSI/NullAlways.ql
+  @_namespace com.lgtm/csharp-queries
++ semmlecode-csharp-queries/CSI/NullMaybe.ql
+  @_namespace com.lgtm/csharp-queries
++ semmlecode-csharp-queries/Complexity/BlockWithTooManyStatements.ql
+  @_namespace com.lgtm/csharp-queries
++ semmlecode-csharp-queries/Complexity/ComplexCondition.ql
+  @_namespace com.lgtm/csharp-queries
++ semmlecode-csharp-queries/Concurrency/FutileSyncOnField.ql
+  @_namespace com.lgtm/csharp-queries
++ semmlecode-csharp-queries/Concurrency/LockOrder.ql
+  @_namespace com.lgtm/csharp-queries
++ semmlecode-csharp-queries/Concurrency/LockThis.ql
+  @_namespace com.lgtm/csharp-queries
++ semmlecode-csharp-queries/Concurrency/LockedWait.ql
+  @_namespace com.lgtm/csharp-queries
++ semmlecode-csharp-queries/Concurrency/SynchSetUnsynchGet.ql
+  @_namespace com.lgtm/csharp-queries
++ semmlecode-csharp-queries/Concurrency/UnsafeLazyInitialization.ql
+  @_namespace com.lgtm/csharp-queries
++ semmlecode-csharp-queries/Concurrency/UnsynchronizedStaticAccess.ql
+  @_namespace com.lgtm/csharp-queries
++ semmlecode-csharp-queries/Configuration/EmptyPasswordInConfigurationFile.ql
+  @_namespace com.lgtm/csharp-queries
++ semmlecode-csharp-queries/Configuration/PasswordInConfigurationFile.ql
+  @_namespace com.lgtm/csharp-queries
++ semmlecode-csharp-queries/Dead Code/DeadStoreOfLocal.ql
+  @_namespace com.lgtm/csharp-queries
++ semmlecode-csharp-queries/Documentation/XmldocMissingSummary.ql
+  @_namespace com.lgtm/csharp-queries
++ semmlecode-csharp-queries/Input Validation/UseOfFileUpload.ql
+  @_namespace com.lgtm/csharp-queries
++ semmlecode-csharp-queries/Input Validation/ValueShadowing.ql
+  @_namespace com.lgtm/csharp-queries
++ semmlecode-csharp-queries/Input Validation/ValueShadowingServerVariable.ql
+  @_namespace com.lgtm/csharp-queries
++ semmlecode-csharp-queries/Language Abuse/CastThisToTypeParameter.ql
+  @_namespace com.lgtm/csharp-queries
++ semmlecode-csharp-queries/Language Abuse/CatchOfGenericException.ql
+  @_namespace com.lgtm/csharp-queries
++ semmlecode-csharp-queries/Language Abuse/ChainedIs.ql
+  @_namespace com.lgtm/csharp-queries
++ semmlecode-csharp-queries/Language Abuse/DubiousDowncastOfThis.ql
+  @_namespace com.lgtm/csharp-queries
++ semmlecode-csharp-queries/Language Abuse/DubiousTypeTestOfThis.ql
+  @_namespace com.lgtm/csharp-queries
++ semmlecode-csharp-queries/Language Abuse/MissedReadonlyOpportunity.ql
+  @_namespace com.lgtm/csharp-queries
++ semmlecode-csharp-queries/Language Abuse/MissedTernaryOpportunity.ql
+  @_namespace com.lgtm/csharp-queries
++ semmlecode-csharp-queries/Language Abuse/MissedUsingOpportunity.ql
+  @_namespace com.lgtm/csharp-queries
++ semmlecode-csharp-queries/Language Abuse/NestedIf.ql
+  @_namespace com.lgtm/csharp-queries
++ semmlecode-csharp-queries/Language Abuse/RethrowException.ql
+  @_namespace com.lgtm/csharp-queries
++ semmlecode-csharp-queries/Language Abuse/SimplifyBoolExpr.ql
+  @_namespace com.lgtm/csharp-queries
++ semmlecode-csharp-queries/Language Abuse/UnusedPropertyValue.ql
+  @_namespace com.lgtm/csharp-queries
++ semmlecode-csharp-queries/Language Abuse/UselessCastToSelf.ql
+  @_namespace com.lgtm/csharp-queries
++ semmlecode-csharp-queries/Language Abuse/UselessNullCoalescingExpression.ql
+  @_namespace com.lgtm/csharp-queries
++ semmlecode-csharp-queries/Language Abuse/UselessTypeTest.ql
+  @_namespace com.lgtm/csharp-queries
++ semmlecode-csharp-queries/Language Abuse/UselessUpcast.ql
+  @_namespace com.lgtm/csharp-queries
++ semmlecode-csharp-queries/Likely Bugs/Collections/ContainerLengthCmpOffByOne.ql
+  @_namespace com.lgtm/csharp-queries
++ semmlecode-csharp-queries/Likely Bugs/Collections/ContainerSizeCmpZero.ql
+  @_namespace com.lgtm/csharp-queries
++ semmlecode-csharp-queries/Likely Bugs/Collections/ReadOnlyContainer.ql
+  @_namespace com.lgtm/csharp-queries
++ semmlecode-csharp-queries/Likely Bugs/Collections/WriteOnlyContainer.ql
+  @_namespace com.lgtm/csharp-queries
++ semmlecode-csharp-queries/Likely Bugs/ConstantComparison.ql
+  @_namespace com.lgtm/csharp-queries
++ semmlecode-csharp-queries/Likely Bugs/DangerousNonShortCircuitLogic.ql
+  @_namespace com.lgtm/csharp-queries
++ semmlecode-csharp-queries/Likely Bugs/Dynamic/BadDynamicCall.ql
+  @_namespace com.lgtm/csharp-queries
++ semmlecode-csharp-queries/Likely Bugs/EqualityCheckOnFloats.ql
+  @_namespace com.lgtm/csharp-queries
++ semmlecode-csharp-queries/Likely Bugs/EqualsArray.ql
+  @_namespace com.lgtm/csharp-queries
++ semmlecode-csharp-queries/Likely Bugs/EqualsUsesAs.ql
+  @_namespace com.lgtm/csharp-queries
++ semmlecode-csharp-queries/Likely Bugs/EqualsUsesIs.ql
+  @_namespace com.lgtm/csharp-queries
++ semmlecode-csharp-queries/Likely Bugs/HashedButNoHash.ql
+  @_namespace com.lgtm/csharp-queries
++ semmlecode-csharp-queries/Likely Bugs/ImpossibleArrayCast.ql
+  @_namespace com.lgtm/csharp-queries
++ semmlecode-csharp-queries/Likely Bugs/IncomparableEquals.ql
+  @_namespace com.lgtm/csharp-queries
++ semmlecode-csharp-queries/Likely Bugs/InconsistentCompareTo.ql
+  @_namespace com.lgtm/csharp-queries
++ semmlecode-csharp-queries/Likely Bugs/NestedLoopsSameVariable.ql
+  @_namespace com.lgtm/csharp-queries
++ semmlecode-csharp-queries/Likely Bugs/ObjectComparison.ql
+  @_namespace com.lgtm/csharp-queries
++ semmlecode-csharp-queries/Likely Bugs/PossibleLossOfPrecision.ql
+  @_namespace com.lgtm/csharp-queries
++ semmlecode-csharp-queries/Likely Bugs/RecursiveEquals.ql
+  @_namespace com.lgtm/csharp-queries
++ semmlecode-csharp-queries/Likely Bugs/RecursiveOperatorEquals.ql
+  @_namespace com.lgtm/csharp-queries
++ semmlecode-csharp-queries/Likely Bugs/ReferenceEqualsOnValueTypes.ql
+  @_namespace com.lgtm/csharp-queries
++ semmlecode-csharp-queries/Likely Bugs/SelfAssignment.ql
+  @_namespace com.lgtm/csharp-queries
++ semmlecode-csharp-queries/Likely Bugs/Statements/EmptyBlock.ql
+  @_namespace com.lgtm/csharp-queries
++ semmlecode-csharp-queries/Likely Bugs/Statements/EmptyLockStatement.ql
+  @_namespace com.lgtm/csharp-queries
++ semmlecode-csharp-queries/Likely Bugs/Statements/UseBraces.ql
+  @_namespace com.lgtm/csharp-queries
++ semmlecode-csharp-queries/Likely Bugs/StaticFieldWrittenByInstance.ql
+  @_namespace com.lgtm/csharp-queries
++ semmlecode-csharp-queries/Likely Bugs/StringBuilderCharInit.ql
+  @_namespace com.lgtm/csharp-queries
++ semmlecode-csharp-queries/Likely Bugs/UncheckedCastInEquals.ql
+  @_namespace com.lgtm/csharp-queries
++ semmlecode-csharp-queries/Linq/BadMultipleIteration.ql
+  @_namespace com.lgtm/csharp-queries
++ semmlecode-csharp-queries/Linq/MissedAllOpportunity.ql
+  @_namespace com.lgtm/csharp-queries
++ semmlecode-csharp-queries/Linq/MissedCastOpportunity.ql
+  @_namespace com.lgtm/csharp-queries
++ semmlecode-csharp-queries/Linq/MissedOfTypeOpportunity.ql
+  @_namespace com.lgtm/csharp-queries
++ semmlecode-csharp-queries/Linq/MissedSelectOpportunity.ql
+  @_namespace com.lgtm/csharp-queries
++ semmlecode-csharp-queries/Linq/MissedWhereOpportunity.ql
+  @_namespace com.lgtm/csharp-queries
++ semmlecode-csharp-queries/Linq/RedundantSelect.ql
+  @_namespace com.lgtm/csharp-queries
++ semmlecode-csharp-queries/Performance/StringBuilderInLoop.ql
+  @_namespace com.lgtm/csharp-queries
++ semmlecode-csharp-queries/Performance/StringConcatenationInLoop.ql
+  @_namespace com.lgtm/csharp-queries
++ semmlecode-csharp-queries/Performance/UseTryGetValue.ql
+  @_namespace com.lgtm/csharp-queries
++ semmlecode-csharp-queries/Security Features/CWE-011/ASPNetDebug.ql
+  @_namespace com.lgtm/csharp-queries
++ semmlecode-csharp-queries/Security Features/CWE-022/TaintedPath.ql
+  @_namespace com.lgtm/csharp-queries
++ semmlecode-csharp-queries/Security Features/CWE-078/CommandInjection.ql
+  @_namespace com.lgtm/csharp-queries
++ semmlecode-csharp-queries/Security Features/CWE-078/StoredCommandInjection.ql
+  @_namespace com.lgtm/csharp-queries
++ semmlecode-csharp-queries/Security Features/CWE-079/StoredXSS.ql
+  @_namespace com.lgtm/csharp-queries
++ semmlecode-csharp-queries/Security Features/CWE-079/XSS.ql
+  @_namespace com.lgtm/csharp-queries
++ semmlecode-csharp-queries/Security Features/CWE-089/SecondOrderSqlInjection.ql
+  @_namespace com.lgtm/csharp-queries
++ semmlecode-csharp-queries/Security Features/CWE-089/SqlInjection.ql
+  @_namespace com.lgtm/csharp-queries
++ semmlecode-csharp-queries/Security Features/CWE-090/LDAPInjection.ql
+  @_namespace com.lgtm/csharp-queries
++ semmlecode-csharp-queries/Security Features/CWE-090/StoredLDAPInjection.ql
+  @_namespace com.lgtm/csharp-queries
++ semmlecode-csharp-queries/Security Features/CWE-094/CodeInjection.ql
+  @_namespace com.lgtm/csharp-queries
++ semmlecode-csharp-queries/Security Features/CWE-099/ResourceInjection.ql
+  @_namespace com.lgtm/csharp-queries
++ semmlecode-csharp-queries/Security Features/CWE-112/MissingXMLValidation.ql
+  @_namespace com.lgtm/csharp-queries
++ semmlecode-csharp-queries/Security Features/CWE-117/LogForging.ql
+  @_namespace com.lgtm/csharp-queries
++ semmlecode-csharp-queries/Security Features/CWE-119/LocalUnvalidatedArithmetic.ql
+  @_namespace com.lgtm/csharp-queries
++ semmlecode-csharp-queries/Security Features/CWE-201/ExposureInTransmittedData.ql
+  @_namespace com.lgtm/csharp-queries
++ semmlecode-csharp-queries/Security Features/CWE-209/ExceptionInformationExposure.ql
+  @_namespace com.lgtm/csharp-queries
++ semmlecode-csharp-queries/Security Features/CWE-248/MissingASPNETGlobalErrorHandler.ql
+  @_namespace com.lgtm/csharp-queries
++ semmlecode-csharp-queries/Security Features/CWE-312/CleartextStorage.ql
+  @_namespace com.lgtm/csharp-queries
++ semmlecode-csharp-queries/Security Features/CWE-352/MissingAntiForgeryTokenValidation.ql
+  @_namespace com.lgtm/csharp-queries
++ semmlecode-csharp-queries/Security Features/CWE-359/ExposureOfPrivateInformation.ql
+  @_namespace com.lgtm/csharp-queries
++ semmlecode-csharp-queries/Security Features/CWE-384/AbandonSession.ql
+  @_namespace com.lgtm/csharp-queries
++ semmlecode-csharp-queries/Security Features/CWE-451/MissingXFrameOptions.ql
+  @_namespace com.lgtm/csharp-queries
++ semmlecode-csharp-queries/Security Features/CWE-548/ASPNetDirectoryListing.ql
+  @_namespace com.lgtm/csharp-queries
++ semmlecode-csharp-queries/Security Features/CWE-601/UrlRedirect.ql
+  @_namespace com.lgtm/csharp-queries
++ semmlecode-csharp-queries/Security Features/CWE-611/UntrustedDataInsecureXml.ql
+  @_namespace com.lgtm/csharp-queries
++ semmlecode-csharp-queries/Security Features/CWE-614/RequireSSL.ql
+  @_namespace com.lgtm/csharp-queries
++ semmlecode-csharp-queries/Security Features/CWE-643/StoredXPathInjection.ql
+  @_namespace com.lgtm/csharp-queries
++ semmlecode-csharp-queries/Security Features/CWE-643/XPathInjection.ql
+  @_namespace com.lgtm/csharp-queries
++ semmlecode-csharp-queries/Security Features/CWE-730/ReDoS.ql
+  @_namespace com.lgtm/csharp-queries
++ semmlecode-csharp-queries/Security Features/CWE-730/RegexInjection.ql
+  @_namespace com.lgtm/csharp-queries
++ semmlecode-csharp-queries/Security Features/CWE-798/HardcodedConnectionString.ql
+  @_namespace com.lgtm/csharp-queries
++ semmlecode-csharp-queries/Security Features/CWE-798/HardcodedCredentials.ql
+  @_namespace com.lgtm/csharp-queries
++ semmlecode-csharp-queries/Security Features/CWE-807/ConditionalBypass.ql
+  @_namespace com.lgtm/csharp-queries
++ semmlecode-csharp-queries/Security Features/CookieWithOverlyBroadDomain.ql
+  @_namespace com.lgtm/csharp-queries
++ semmlecode-csharp-queries/Security Features/CookieWithOverlyBroadPath.ql
+  @_namespace com.lgtm/csharp-queries
++ semmlecode-csharp-queries/Security Features/Encryption using ECB.ql
+  @_namespace com.lgtm/csharp-queries
++ semmlecode-csharp-queries/Security Features/HeaderCheckingDisabled.ql
+  @_namespace com.lgtm/csharp-queries
++ semmlecode-csharp-queries/Security Features/InadequateRSAPadding.ql
+  @_namespace com.lgtm/csharp-queries
++ semmlecode-csharp-queries/Security Features/InsecureRandomness.ql
+  @_namespace com.lgtm/csharp-queries
++ semmlecode-csharp-queries/Security Features/InsufficientKeySize.ql
+  @_namespace com.lgtm/csharp-queries
++ semmlecode-csharp-queries/Security Features/PersistentCookie.ql
+  @_namespace com.lgtm/csharp-queries
++ semmlecode-csharp-queries/Security Features/WeakEncryption.ql
+  @_namespace com.lgtm/csharp-queries
++ semmlecode-csharp-queries/Useless code/DefaultToString.ql
+  @_namespace com.lgtm/csharp-queries
++ semmlecode-csharp-queries/Useless code/FutileConditional.ql
+  @_namespace com.lgtm/csharp-queries
++ semmlecode-csharp-queries/Useless code/IntGetHashCode.ql
+  @_namespace com.lgtm/csharp-queries
++ semmlecode-csharp-queries/Useless code/RedundantToStringCall.ql
+  @_namespace com.lgtm/csharp-queries
++ semmlecode-csharp-queries/Useless code/UnusedLabel.ql
+  @_namespace com.lgtm/csharp-queries
++ semmlecode-csharp-queries/external/DuplicateMethod.ql
+  @_namespace com.lgtm/csharp-queries
++ semmlecode-csharp-queries/external/MostlyDuplicateClass.ql
+  @_namespace com.lgtm/csharp-queries
++ semmlecode-csharp-queries/external/MostlyDuplicateFile.ql
+  @_namespace com.lgtm/csharp-queries
++ semmlecode-csharp-queries/external/MostlyDuplicateMethod.ql
+  @_namespace com.lgtm/csharp-queries
++ semmlecode-csharp-queries/external/MostlySimilarFile.ql
+  @_namespace com.lgtm/csharp-queries

csharp/config/suites/lgtm/csharp-lgtm

@@ -0,0 +1,2 @@
+@import "csharp-queries-lgtm"
+@import "csharp-metrics-lgtm"

csharp/config/suites/lgtm/csharp-metrics-lgtm

@@ -0,0 +1,16 @@
++ odasa-csharp-metrics/Files/FLinesOfCode.ql: /Metrics/Size
+    @_namespace com.lgtm/csharp-queries
++ odasa-csharp-metrics/Files/FLinesOfComment.ql: /Metrics/Documentation
+    @_namespace com.lgtm/csharp-queries
++ odasa-csharp-metrics/Files/FLinesOfCommentedCode.ql: /Metrics/Documentation
+    @_namespace com.lgtm/csharp-queries
++ odasa-csharp-metrics/Files/FLinesOfDuplicatedCode.ql: /Metrics/Coupling
+    @_namespace com.lgtm/csharp-queries
++ odasa-csharp-metrics/Files/FNumberOfTests.ql: /Metrics/Size
+    @_namespace com.lgtm/csharp-queries
+
++ semmlecode-csharp-queries/Metrics/Dependencies/ExternalDependencies.ql
+    @_namespace com.lgtm/csharp-queries
++ semmlecode-csharp-queries/Metrics/Dependencies/ExternalDependenciesSourceLinks.ql
+    @_namespace com.lgtm/csharp-queries
+

csharp/config/suites/lgtm/csharp-queries-lgtm

@@ -0,0 +1,8 @@
++ semmlecode-csharp-queries/definitions.ql
+    @_namespace com.lgtm/csharp-queries
++ semmlecode-csharp-queries/AlertSuppression.ql
+    @_namespace com.lgtm/csharp-queries
++ semmlecode-csharp-queries/filters/ClassifyFiles.ql
+    @_namespace com.lgtm/csharp-queries
+
+@import "csharp-alerts-lgtm"