Swap order of equality for easier comprehension

owen-mc · owen-mc · commit a062d51f61b1 · 2026-01-06T23:31:13.000Z
diff --git a/go/ql/lib/semmle/go/security/Xss.qll b/go/ql/lib/semmle/go/security/Xss.qll
@@ -139,10 +139,10 @@ module SharedXss {
     HtmlTemplateSanitizer() {
       exists(Method m, DataFlow::CallNode call | m = call.getCall().getTarget() |
         m.hasQualifiedName("html/template", "Template", "ExecuteTemplate") and
-        call.getArgument(2) = this
+        this = call.getArgument(2)
         or
         m.hasQualifiedName("html/template", "Template", "Execute") and
-        call.getArgument(1) = this
+        this = call.getArgument(1)
       )
     }
   }

Original file line number	Diff line number	Diff line change
`@@ -139,10 +139,10 @@ module SharedXss {`
`139`	`139`	`HtmlTemplateSanitizer() {`
`140`	`140`	`exists(Method m, DataFlow::CallNode call \| m = call.getCall().getTarget() \|`
`141`	`141`	`m.hasQualifiedName("html/template", "Template", "ExecuteTemplate") and`
`142`		`- call.getArgument(2) = this`
	`142`	`+ this = call.getArgument(2)`
`143`	`143`	`or`
`144`	`144`	`m.hasQualifiedName("html/template", "Template", "Execute") and`
`145`		`- call.getArgument(1) = this`
	`145`	`+ this = call.getArgument(1)`
`146`	`146`	`)`
`147`	`147`	`}`
`148`	`148`	`}`