Skip to content

Commit a13fb8e

Browse files
committed
JS: Handle RHS in more cases
1 parent 1e5f0a4 commit a13fb8e

File tree

1 file changed

+13
-3
lines changed

1 file changed

+13
-3
lines changed

javascript/ql/src/semmle/javascript/GlobalAccessPaths.qll

Lines changed: 13 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -154,9 +154,9 @@ module GlobalAccessPath {
154154
baseName = fromRhs(base)
155155
)
156156
or
157-
exists(AssignExpr assign |
158-
node = assign.getRhs().flow() and
159-
result = assign.getLhs().(GlobalVarAccess).getName()
157+
exists(GlobalVariable var |
158+
node = var.getAnAssignedExpr().flow() and
159+
result = var.getName()
160160
)
161161
or
162162
exists(FunctionDeclStmt fun |
@@ -168,6 +168,16 @@ module GlobalAccessPath {
168168
node = DataFlow::valueNode(cls) and
169169
result = cls.getIdentifier().(GlobalVarDecl).getName()
170170
)
171+
or
172+
exists(EnumDeclaration decl |
173+
node = DataFlow::valueNode(decl) and
174+
result = decl.getIdentifier().(GlobalVarDecl).getName()
175+
)
176+
or
177+
exists(NamespaceDeclaration decl |
178+
node = DataFlow::valueNode(decl) and
179+
result = decl.getId().(GlobalVarDecl).getName()
180+
)
171181
}
172182

173183
/**

0 commit comments

Comments
 (0)