Rust: Remove store step for repeat operand in array expression

Author: paldepind

rust/ql/lib/codeql/rust/dataflow/internal/DataFlowImpl.qll

@@ -984,11 +984,12 @@ module RustDataFlow implements InputSig<Location> {
         node2.asExpr() = tuple
       )
       or
-      exists(ArrayExprCfgNode arr |
-        c instanceof ArrayElementContent and
-        node1.asExpr() = arr.getAnExpr() and
-        node2.asExpr() = arr
-      )
+      c instanceof ArrayElementContent and
+      node1.asExpr() =
+        [
+          node2.asExpr().(ArrayRepeatExprCfgNode).getRepeatOperand(),
+          node2.asExpr().(ArrayListExprCfgNode).getAnExpr()
+        ]
       or
       tupleAssignment(node1, node2.(PostUpdateNode).getPreUpdateNode(), c)
       or

rust/ql/test/library-tests/dataflow/local/DataFlowStep.expected

@@ -524,7 +524,6 @@ storeStep
 | main.rs:336:20:336:20 | 2 | array[] | main.rs:336:16:336:33 | [...] |
 | main.rs:336:23:336:32 | source(...) | array[] | main.rs:336:16:336:33 | [...] |
 | main.rs:340:17:340:26 | source(...) | array[] | main.rs:340:16:340:31 | [...; 10] |
-| main.rs:340:29:340:30 | 10 | array[] | main.rs:340:16:340:31 | [...; 10] |
 | main.rs:344:17:344:17 | 1 | array[] | main.rs:344:16:344:24 | [...] |
 | main.rs:344:20:344:20 | 2 | array[] | main.rs:344:16:344:24 | [...] |
 | main.rs:344:23:344:23 | 3 | array[] | main.rs:344:16:344:24 | [...] |