Skip to content

Commit a4890ef

Browse files
committed
C++: Add annotations describing whether the flow is an instance of field-to-object flow
1 parent 3cbc4cf commit a4890ef

File tree

1 file changed

+9
-9
lines changed

1 file changed

+9
-9
lines changed

cpp/ql/test/library-tests/dataflow/DefaultTaintTracking/defaulttainttracking.cpp

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -161,20 +161,20 @@ void test_field_to_obj_taint_object(Point p) {
161161

162162
void test_field_to_obj_taint_object_addrof(Point p) {
163163
taint_x(&p);
164-
sink(p); // tainted
165-
sink(&p); // tainted
164+
sink(p); // tainted [field -> object]
165+
sink(&p); // tainted [field -> object]
166166
sink(p.x); // tainted
167167
}
168168

169169
void test_field_to_obj_taint_pointer(Point* pp) {
170170
pp->x = getenv("VAR")[0];
171-
sink(pp); // tainted
171+
sink(pp); // tainted [field -> object]
172172
sink(*pp); // not tainted
173173
}
174174

175175
void call_sink_on_object(Point* pp) {
176-
sink(pp); // tainted
177-
sink(*pp); // tainted
176+
sink(pp); // tainted [field -> object]
177+
sink(*pp); // tainted [field -> object]
178178
}
179179

180180
void test_field_to_obj_taint_call_sink(Point* pp) {
@@ -184,7 +184,7 @@ void test_field_to_obj_taint_call_sink(Point* pp) {
184184

185185
void test_field_to_obj_taint_through_setter(Point* pp) {
186186
taint_x(pp);
187-
sink(pp); // tainted
187+
sink(pp); // tainted [field -> object]
188188
sink(*pp); // not tainted
189189
}
190190

@@ -200,12 +200,12 @@ void test_field_to_obj_local_variable() {
200200
void test_field_to_obj_taint_array(Point* pp, int i) {
201201
pp[0].x = getenv("VAR")[0];
202202
sink(pp[i]); // not tainted
203-
sink(pp); // tainted
203+
sink(pp); // tainted [field -> object]
204204
sink(*pp); // not tainted
205205
}
206206

207207
void test_field_to_obj_test_pointer_arith(Point* pp) {
208208
(pp + sizeof(*pp))->x = getenv("VAR")[0];
209-
sink(pp); // tainted
210-
sink(pp + sizeof(*pp)); // tainted
209+
sink(pp); // tainted [field -> object]
210+
sink(pp + sizeof(*pp)); // tainted [field -> object]
211211
}

0 commit comments

Comments
 (0)