C#: Move fields to locals where possible

Author: tamasvajk

csharp/extractor/Semmle.Extraction.CSharp.Standalone/BuildAnalysis.cs

@@ -53,7 +53,6 @@ internal sealed class BuildAnalysis : IBuildAnalysis, IDisposable
         private readonly IDictionary<string, bool> usedReferences = new ConcurrentDictionary<string, bool>();
         private readonly IDictionary<string, bool> sources = new ConcurrentDictionary<string, bool>();
         private readonly IDictionary<string, string> unresolvedReferences = new ConcurrentDictionary<string, string>();
-        private readonly DirectoryInfo sourceDir;
         private int failedProjects, succeededProjects;
         private readonly string[] allSources;
         private int conflictedReferences = 0;
@@ -68,7 +67,7 @@ public BuildAnalysis(Options options, IProgressMonitor progress)
             var startTime = DateTime.Now;
 
             progressMonitor = progress;
-            sourceDir = new DirectoryInfo(options.SrcDir);
+            var sourceDir = new DirectoryInfo(options.SrcDir);
 
             progressMonitor.FindingFiles(options.SrcDir);
 

csharp/extractor/Semmle.Extraction.CSharp/Entities/Expressions/MemberAccess.cs

@@ -6,8 +6,6 @@ namespace Semmle.Extraction.CSharp.Entities.Expressions
 {
     internal class MemberAccess : Expression
     {
-        private readonly IEntity target;
-
         private MemberAccess(ExpressionNodeInfo info, ExpressionSyntax qualifier, ISymbol target) : base(info)
         {
             var trapFile = info.Context.TrapWriter.Writer;
@@ -20,8 +18,8 @@ private MemberAccess(ExpressionNodeInfo info, ExpressionSyntax qualifier, ISymbo
             }
             else
             {
-                this.target = cx.CreateEntity(target);
-                trapFile.expr_access(this, this.target);
+                var t = cx.CreateEntity(target);
+                trapFile.expr_access(this, t);
             }
         }