Add test cases to UselessCastToSelf

tamasvajk · tamasvajk · commit a635503be098 · 2020-09-28T11:04:22.000+02:00
diff --git a/csharp/ql/test/query-tests/Language Abuse/UselessCastToSelf/UselessCastToSelf.cs b/csharp/ql/test/query-tests/Language Abuse/UselessCastToSelf/UselessCastToSelf.cs
@@ -18,4 +18,13 @@ void f()
         var good6 = (Action<int>)(delegate (int x) { });
         var good7 = (Action<int>)((int x) => { });
     }
+
+    enum Enum
+    {
+        A = 2,
+        B = 1 | A,
+        C = 1 | (int)A, // BAD
+        D = 9 | (32 << A),
+        E = 9 | (32 << (int)A) // BAD
+    }
 }
diff --git a/csharp/ql/test/query-tests/Language Abuse/UselessCastToSelf/UselessCastToSelf.expected b/csharp/ql/test/query-tests/Language Abuse/UselessCastToSelf/UselessCastToSelf.expected
@@ -1,3 +1,5 @@
 | UselessCastToSelf.cs:8:20:8:25 | (...) ... | This cast is redundant because the expression already has type Int32. |
 | UselessCastToSelf.cs:9:20:9:29 | (...) ... | This cast is redundant because the expression already has type Test. |
 | UselessCastToSelf.cs:10:20:10:31 | ... as ... | This cast is redundant because the expression already has type Test. |
+| UselessCastToSelf.cs:26:17:26:22 | (...) ... | This cast is redundant because the expression already has type Int32. |
+| UselessCastToSelf.cs:28:24:28:29 | (...) ... | This cast is redundant because the expression already has type Int32. |

Original file line number	Diff line number	Diff line change
`@@ -18,4 +18,13 @@ void f()`
`18`	`18`	`var good6 = (Action<int>)(delegate (int x) { });`
`19`	`19`	`var good7 = (Action<int>)((int x) => { });`
`20`	`20`	`}`
	`21`	`+`
	`22`	`+ enum Enum`
	`23`	`+ {`
	`24`	`+ A = 2,`
	`25`	`+ B = 1 \| A,`
	`26`	`+ C = 1 \| (int)A, // BAD`
	`27`	`+ D = 9 \| (32 << A),`
	`28`	`+ E = 9 \| (32 << (int)A) // BAD`
	`29`	`+ }`
`21`	`30`	`}`