JS: Port Routing test

Author: asgerf

javascript/ql/test/library-tests/Routing/test.expected

@@ -0,0 +1,2 @@
+legacyDataFlowDifference
+consistencyIssue

javascript/ql/test/library-tests/Routing/test.ql

@@ -3,18 +3,34 @@ import testUtilities.ConsistencyChecking
 
 API::Node testInstance() { result = API::moduleImport("@example/test").getInstance() }
 
-class Taint extends TaintTracking::Configuration {
-  Taint() { this = "Taint" }
-
-  override predicate isSource(DataFlow::Node node) {
+module TestConfig implements DataFlow::ConfigSig {
+  predicate isSource(DataFlow::Node node) {
     node.(DataFlow::CallNode).getCalleeName() = "source"
     or
     node = testInstance().getMember("getSource").getReturn().asSource()
   }
 
-  override predicate isSink(DataFlow::Node node) {
+  predicate isSink(DataFlow::Node node) {
     node = any(DataFlow::CallNode call | call.getCalleeName() = "sink").getAnArgument()
     or
     node = testInstance().getMember("getSink").getAParameter().asSink()
   }
 }
+
+module TestFlow = TaintTracking::Global<TestConfig>;
+
+class Consistency extends ConsistencyConfiguration {
+  Consistency() { this = "Consistency" }
+
+  override DataFlow::Node getAnAlert() { TestFlow::flowTo(result) }
+}
+
+class LegacyConfig extends TaintTracking::Configuration {
+  LegacyConfig() { this = "LegacyConfig" }
+
+  override predicate isSource(DataFlow::Node source) { TestConfig::isSource(source) }
+
+  override predicate isSink(DataFlow::Node sink) { TestConfig::isSink(sink) }
+}
+
+import testUtilities.LegacyDataFlowDiff::DataFlowDiff<TestFlow, LegacyConfig>