Java: Update hand written summary for writeLines as the generated one will be ignored.

michaelnebel · michaelnebel · commit ad4d8304ed0a · 2022-05-30T08:16:58.000+02:00
diff --git a/java/ql/lib/semmle/code/java/frameworks/apache/IO.qll b/java/ql/lib/semmle/code/java/frameworks/apache/IO.qll
@@ -14,7 +14,8 @@ private class ApacheCommonsIOCustomSummaryCsv extends SummaryModelCsv {
     row =
       [
         "org.apache.commons.io;IOUtils;false;toBufferedInputStream;;;Argument[0];ReturnValue;taint",
-        "org.apache.commons.io;IOUtils;true;writeLines;(Collection,String,Writer);;Argument[0];Argument[2];taint",
+        "org.apache.commons.io;IOUtils;true;writeLines;(Collection,String,Writer);;Argument[0].Element;Argument[2];taint",
+        "org.apache.commons.io;IOUtils;true;writeLines;(Collection,String,Writer);;Argument[1];Argument[2];taint",
         "org.apache.commons.io;IOUtils;true;toByteArray;(Reader);;Argument[0];ReturnValue;taint",
         "org.apache.commons.io;IOUtils;true;toByteArray;(Reader,String);;Argument[0];ReturnValue;taint",
       ]

Original file line number	Diff line number	Diff line change
`@@ -14,7 +14,8 @@ private class ApacheCommonsIOCustomSummaryCsv extends SummaryModelCsv {`
`14`	`14`	`row =`
`15`	`15`	`[`
`16`	`16`	`"org.apache.commons.io;IOUtils;false;toBufferedInputStream;;;Argument[0];ReturnValue;taint",`
`17`		`- "org.apache.commons.io;IOUtils;true;writeLines;(Collection,String,Writer);;Argument[0];Argument[2];taint",`
	`17`	`+ "org.apache.commons.io;IOUtils;true;writeLines;(Collection,String,Writer);;Argument[0].Element;Argument[2];taint",`
	`18`	`+ "org.apache.commons.io;IOUtils;true;writeLines;(Collection,String,Writer);;Argument[1];Argument[2];taint",`
`18`	`19`	`"org.apache.commons.io;IOUtils;true;toByteArray;(Reader);;Argument[0];ReturnValue;taint",`
`19`	`20`	`"org.apache.commons.io;IOUtils;true;toByteArray;(Reader,String);;Argument[0];ReturnValue;taint",`
`20`	`21`	`]`