Merge pull request #1098 from markshannon/python-2-print

Python: Don't report Python 2 print statements as having no effect.

Author: taus-semmle

python/ql/src/Statements/StatementNoEffect.ql

@@ -95,6 +95,14 @@ predicate in_raises_test(Expr e) {
     )
 }
 
+/** Holds if expression has the form of a Python 2 `print >> out, ...` statement */
+predicate python2_print(Expr e) {
+    e.(BinaryExpr).getLeft().(Name).getId() = "print" and
+    e.(BinaryExpr).getOp() instanceof RShift
+    or
+    python2_print(e.(Tuple).getElt(0))
+}
+
 predicate no_effect(Expr e) {
     not e instanceof StrConst and
     not ((StrConst)e).isDocString() and
@@ -107,7 +115,8 @@ predicate no_effect(Expr e) {
         not maybe_side_effecting_attribute(sub)
     ) and
     not in_notebook(e) and
-    not in_raises_test(e)
+    not in_raises_test(e) and
+    not python2_print(e)
 }
 
 from ExprStmt stmt

python/ql/test/query-tests/Statements/no_effect/test.py

@@ -133,3 +133,7 @@ def do_action(action):
         stop()
     else:
         raise ValueError(action)
+
+#Python 2 print
+print >> out, message
+