C++: Fix PR feedback

Dave Bartolomeo · Dave Bartolomeo · commit afd2f58f9fa6 · 2021-04-12T18:21:05.000-04:00
diff --git a/cpp/ql/src/semmle/code/cpp/ir/implementation/raw/internal/TranslatedCall.qll b/cpp/ql/src/semmle/code/cpp/ir/implementation/raw/internal/TranslatedCall.qll
@@ -495,10 +495,8 @@ class TranslatedSideEffect extends TranslatedElement, TTranslatedArgumentSideEff
   override Instruction getFirstInstruction() { result = getInstruction(OnlyInstructionTag()) }
 
   override predicate hasInstruction(Opcode opcode, InstructionTag tag, CppType type) {
-    (
-      tag = OnlyInstructionTag() and
-      opcode = sideEffectOpcode
-    ) and
+    tag = OnlyInstructionTag() and
+    opcode = sideEffectOpcode and
     (
       isWrite() and
       (

Original file line number	Diff line number	Diff line change
`@@ -495,10 +495,8 @@ class TranslatedSideEffect extends TranslatedElement, TTranslatedArgumentSideEff`
`495`	`495`	`override Instruction getFirstInstruction() { result = getInstruction(OnlyInstructionTag()) }`
`496`	`496`
`497`	`497`	`override predicate hasInstruction(Opcode opcode, InstructionTag tag, CppType type) {`
`498`		`- (`
`499`		`- tag = OnlyInstructionTag() and`
`500`		`- opcode = sideEffectOpcode`
`501`		`- ) and`
	`498`	`+ tag = OnlyInstructionTag() and`
	`499`	`+ opcode = sideEffectOpcode and`
`502`	`500`	`(`
`503`	`501`	`isWrite() and`
`504`	`502`	`(`