Swift: remove unused decl properties

Author: redsun82

swift/codegen/schema.yml

@@ -898,7 +898,6 @@ BoundGenericStructType:
 
 ClassType:
   _extends: NominalType
-  decl: ClassDecl
 
 EnumType:
   _extends: NominalType
@@ -908,7 +907,6 @@ ProtocolType:
 
 StructType:
   _extends: NominalType
-  decl: StructDecl
 
 ArraySliceType:
   _extends: UnarySyntaxSugarType

swift/extractor/visitors/TypeVisitor.h

@@ -28,13 +28,13 @@ class TypeVisitor : public TypeVisitorBase<TypeVisitor> {
 
   void visitStructType(swift::StructType* type) {
     auto label = dispatcher_.assignNewLabel(type);
-    dispatcher_.emit(StructTypesTrap{label, dispatcher_.fetchLabel(type->getDecl())});
+    dispatcher_.emit(StructTypesTrap{label});
     emitAnyGenericType(type, label);
   }
 
   void visitClassType(swift::ClassType* type) {
     auto label = dispatcher_.assignNewLabel(type);
-    dispatcher_.emit(ClassTypesTrap{label, dispatcher_.fetchLabel(type->getDecl())});
+    dispatcher_.emit(ClassTypesTrap{label});
     emitAnyGenericType(type, label);
   }
 

swift/ql/lib/codeql/swift/generated/type/ClassType.qll

@@ -1,14 +1,6 @@
 // generated by codegen/codegen.py
-import codeql.swift.elements.decl.ClassDecl
 import codeql.swift.elements.type.NominalType
 
 class ClassTypeBase extends @class_type, NominalType {
   override string getAPrimaryQlClass() { result = "ClassType" }
-
-  ClassDecl getDecl() {
-    exists(ClassDecl x |
-      class_types(this, x) and
-      result = x.resolve()
-    )
-  }
 }

swift/ql/lib/codeql/swift/generated/type/StructType.qll

@@ -1,14 +1,6 @@
 // generated by codegen/codegen.py
 import codeql.swift.elements.type.NominalType
-import codeql.swift.elements.decl.StructDecl
 
 class StructTypeBase extends @struct_type, NominalType {
   override string getAPrimaryQlClass() { result = "StructType" }
-
-  StructDecl getDecl() {
-    exists(StructDecl x |
-      struct_types(this, x) and
-      result = x.resolve()
-    )
-  }
 }

swift/ql/lib/swift.dbscheme

@@ -1774,8 +1774,7 @@ bound_generic_struct_types(
 );
 
 class_types(
-  unique int id: @class_type,
-  int decl: @class_decl ref
+  unique int id: @class_type
 );
 
 enum_types(
@@ -1787,8 +1786,7 @@ protocol_types(
 );
 
 struct_types(
-  unique int id: @struct_type,
-  int decl: @struct_decl ref
+  unique int id: @struct_type
 );
 
 array_slice_types(